linux-kernel - Re: [PATCH v4 2/2] clk: at91: Add sama5d2 suspend/resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170605142558.7x2eip4o66uj6eby@piout.net>
Date:   Mon, 5 Jun 2017 16:25:58 +0200
From:   Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:     Stephen Boyd <sboyd@...eaurora.org>
Cc:     Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] clk: at91: Add sama5d2 suspend/resume

Hi,

On 01/06/2017 at 00:46:44 -0700, Stephen Boyd wrote:
> > +
> > +static u8 registered_ids[PMC_MAX_IDS];
> > +
> > +void pmc_register_id(u8 id)
> > +{
> 
> Shouldn't this also be inside CONFIG_PM? And then
> pmc_register_id() is a nop function when CONFIG_PM=n?
> 

I'll do that. I'll rebase on top of clk-next once you fix my silly
mistake.

> > +	int i;
> > +
> > +	for (i = 0; i < PMC_MAX_IDS; i++) {
> > +		if (registered_ids[i] == 0) {
> > +			registered_ids[i] = id;
> > +			break;
> > +		}
> > +		if (registered_ids[i] == id)
> > +			break;
> > +	}
> > +}
> 
> -- 
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com