linux-kernel - Re: [PATCH] qla2xxx: remove writeq/readq function definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DE09FD4F-E485-42E6-868D-2AE2FD1485BE@cavium.com>
Date:   Mon, 5 Jun 2017 15:57:12 +0000
From:   "Madhani, Himanshu" <Himanshu.Madhani@...ium.com>
To:     Corentin Labbe <clabbe.montjoie@...il.com>
CC:     Dept-Eng QLA2xxx Upstream <qla2xxx-upstream@...ium.com>,
        "jejb@...ux.vnet.ibm.com" <jejb@...ux.vnet.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        linux-scsi <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] qla2xxx: remove writeq/readq function definitions


> On Jun 2, 2017, at 4:32 AM, Corentin Labbe <clabbe.montjoie@...il.com> wrote:
> 
> Instead of rewriting write/readq, use linux/io-64-nonatomic-lo-hi.h which
> already have them.
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com>
> ---
> drivers/scsi/qla2xxx/qla_nx.h | 17 ++---------------
> 1 file changed, 2 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_nx.h b/drivers/scsi/qla2xxx/qla_nx.h
> index 77624eac95a4..71a41093530e 100644
> --- a/drivers/scsi/qla2xxx/qla_nx.h
> +++ b/drivers/scsi/qla2xxx/qla_nx.h
> @@ -7,6 +7,8 @@
> #ifndef __QLA_NX_H
> #define __QLA_NX_H
> 
> +#include <linux/io-64-nonatomic-lo-hi.h>
> +
> /*
>  * Following are the states of the Phantom. Phantom will set them and
>  * Host will read to check if the fields are correct.
> @@ -819,21 +821,6 @@ struct qla82xx_uri_data_desc{
> #define MIU_TEST_AGT_WRDATA_UPPER_LO		(0x0b0)
> #define	MIU_TEST_AGT_WRDATA_UPPER_HI		(0x0b4)
> 
> -#ifndef readq
> -static inline u64 readq(void __iomem *addr)
> -{
> -	return readl(addr) | (((u64) readl(addr + 4)) << 32LL);
> -}
> -#endif
> -
> -#ifndef writeq
> -static inline void writeq(u64 val, void __iomem *addr)
> -{
> -	writel(((u32) (val)), (addr));
> -	writel(((u32) (val >> 32)), (addr + 4));
> -}
> -#endif
> -
> /* Request and response queue size */
> #define REQUEST_ENTRY_CNT_82XX		128	/* Number of request entries. */
> #define RESPONSE_ENTRY_CNT_82XX		128	/* Number of response entries.*/
> -- 
> 2.13.0
> 

Looks Good. Thanks 

Acked-by: Himanshu Madhani <himanshu.madhani@...ium.com>


- Himanshu