linux-kernel - Re: [PATCH v2 1/5] acpi, nfit: Switch to use new generic UUID API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1496679529.22624.14.camel@linux.intel.com>
Date:   Mon, 05 Jun 2017 19:18:49 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Christoph Hellwig <hch@....de>
Cc:     linux-kernel@...r.kernel.org,
        "Rafael J . Wysocki" <rjw@...ysocki.net>,
        linux-acpi@...r.kernel.org,
        Dan Williams <dan.j.williams@...el.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Borislav Petkov <bp@...e.de>, intel-gfx@...ts.freedesktop.org
Subject: Re: [PATCH v2 1/5] acpi, nfit: Switch to use new generic UUID API

On Mon, 2017-06-05 at 18:01 +0200, Christoph Hellwig wrote:
> >  	for (i = 0; i < NFIT_UUID_MAX; i++)
> > -		if (memcmp(to_nfit_uuid(i), spa->range_guid, 16) ==
> > 0)
> > +		if (!guid_equal(to_nfit_uuid(i), (guid_t *)&spa-
> > >range_guid))
> >  			return i;
> 
> I think this should be guid_equal without the "!"

Right.


-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy