linux-kernel - Re: [PATCH -mm 05/13] block, THP: Make block_device_operations.rw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87a85n1c5h.fsf@yhuang-dev.intel.com>
Date:   Mon, 05 Jun 2017 09:00:42 +0800
From:   "Huang\, Ying" <ying.huang@...el.com>
To:     Ross Zwisler <ross.zwisler@...ux.intel.com>
Cc:     "Huang\, Ying" <ying.huang@...el.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Jens Axboe <axboe@...nel.dk>, Minchan Kim <minchan@...nel.org>,
        Ross Zwisler <ross.zwisler@...el.com>,
        <linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>,
        Johannes Weiner <hannes@...xchg.org>,
        <linux-nvdimm@...ts.01.org>
Subject: Re: [PATCH -mm 05/13] block, THP: Make block_device_operations.rw_page support THP

Ross Zwisler <ross.zwisler@...ux.intel.com> writes:

> On Thu, May 25, 2017 at 02:46:27PM +0800, Huang, Ying wrote:
>> From: Huang Ying <ying.huang@...el.com>
>> 
>> The .rw_page in struct block_device_operations is used by the swap
>> subsystem to read/write the page contents from/into the corresponding
>> swap slot in the swap device.  To support the THP (Transparent Huge
>> Page) swap optimization, the .rw_page is enhanced to support to
>> read/write THP if possible.
>> 
>> Signed-off-by: "Huang, Ying" <ying.huang@...el.com>
>> Cc: Johannes Weiner <hannes@...xchg.org>
>> Cc: Minchan Kim <minchan@...nel.org>
>> Cc: Dan Williams <dan.j.williams@...el.com>
>> Cc: Ross Zwisler <ross.zwisler@...el.com>
>> Cc: Vishal L Verma <vishal.l.verma@...el.com>
>> Cc: Jens Axboe <axboe@...nel.dk>
>> Cc: linux-nvdimm@...ts.01.org
>> ---
>>  drivers/block/brd.c           |  6 +++++-
>>  drivers/block/zram/zram_drv.c |  2 ++
>>  drivers/nvdimm/btt.c          |  4 +++-
>>  drivers/nvdimm/pmem.c         | 42 +++++++++++++++++++++++++++++++-----------
>>  4 files changed, 41 insertions(+), 13 deletions(-)
>
> The changes in brd.c, zram_drv.c and pmem.c look good to me.  For those bits
> you can add: 
>
> Reviewed-by: Ross Zwisler <ross.zwisler@...ux.intel.com>

Thanks!

> I think we still want Vishal to make sure that the BTT changes are okay.  I
> don't know that code well enough to know whether it's safe to throw 512 pages
> at btt_[read|write]_pg().
>
> Also, Ying, next time can you please CC me (and probably the linux-nvdimm
> list) on the whole series?  It would give us more context on what the larger
> change is, allow us to see the cover letter, allow us to test with all the
> patches in the series, etc.  It's pretty easy for reviewers to skip over the
> patches we don't care about or aren't in our area.

Sure.

Best Regards,
Huang, Ying

> Thanks,
> - Ross