lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 7 Jun 2017 00:54:07 +0100 From: Colin King <colin.king@...onical.com> To: Jeff Kirsher <jeffrey.t.kirsher@...el.com>, intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH] i40evf: remove redundant null check on key From: Colin Ian King <colin.king@...onical.com> key has previously been null checked so the subsequent null check is redundant as key can never be null at that point, so remove it. Detected by CoverityScan, CID#1357164 ("Logically dead code") Signed-off-by: Colin Ian King <colin.king@...onical.com> --- drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c b/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c index 9bb2cc7dd4e4..838e57c6e176 100644 --- a/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c +++ b/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c @@ -732,9 +732,7 @@ static int i40evf_set_rxfh(struct net_device *netdev, const u32 *indir, if (!indir) return 0; - if (key) { - memcpy(adapter->rss_key, key, adapter->rss_key_size); - } + memcpy(adapter->rss_key, key, adapter->rss_key_size); /* Each 32 bits pointed by 'indir' is stored with a lut entry */ for (i = 0; i < adapter->rss_lut_size; i++) -- 2.11.0
Powered by blists - more mailing lists