linux-kernel - Re: [PATCH V1] mfd: da9061: fix to remove BBAT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Jun 2017 08:16:09 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Steve Twiss <stwiss.opensource@...semi.com>
Cc:     LINUX-KERNEL <linux-kernel@...r.kernel.org>,
        Support Opensource <support.opensource@...semi.com>
Subject: Re: [PATCH V1] mfd: da9061: fix to remove BBAT_CONT register from
 chip model

On Mon, 05 Jun 2017, Steve Twiss wrote:

> From: Steve Twiss <stwiss.opensource@...semi.com>
> 
> Remove the register DA9062AA_BBAT_CONT (0x0C5) from the DA9061 chip model
> regmap access ranges. This applies to both da9061_aa_readable_ranges[]
> and da9061_aa_writeable_ranges[].
> 
> This change is to correct the DA9061 chip model and align it with the
> latest DA9061 Datasheet.
> 
> This register previously appeared in the DA9061 Datasheet, Revision 3.2,
> 01-Mar-2016 and has been removed from later DA9061 datasheet from Dialog,
> Revision 3.3, 04-Apr-2017.
> 
> Signed-off-by: Steve Twiss <stwiss.opensource@...semi.com>
> 
> ---
> 
> Hi Lee,
> 
> This is a fix to remove DA9062AA_BBAT_CONT register from the DA9061
> regmap read/write access tables. It only applies to the DA9061 chip,
> and does not affect the DA9062.
> 
> No existing kernel code tries to access this register, so the change is
> just a formality to correct the DA9061 chip model and align it with the
> DA9061 Datasheet.
> 
> This patch applies against linux-next and v4.12-rc3
> 
> Regards,
> Steve Twiss, Dialog Semiconductor
> 
> 
>  drivers/mfd/da9062-core.c | 6 ------
>  1 file changed, 6 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/da9062-core.c b/drivers/mfd/da9062-core.c
> index 7f5e8be..fe18115 100644
> --- a/drivers/mfd/da9062-core.c
> +++ b/drivers/mfd/da9062-core.c
> @@ -429,9 +429,6 @@ static int da9062_get_device_type(struct da9062 *chip)
>  		.range_min = DA9062AA_VLDO1_B,
>  		.range_max = DA9062AA_VLDO4_B,
>  	}, {
> -		.range_min = DA9062AA_BBAT_CONT,
> -		.range_max = DA9062AA_BBAT_CONT,
> -	}, {
>  		.range_min = DA9062AA_INTERFACE,
>  		.range_max = DA9062AA_CONFIG_E,
>  	}, {
> @@ -514,9 +511,6 @@ static int da9062_get_device_type(struct da9062 *chip)
>  		.range_min = DA9062AA_VLDO1_B,
>  		.range_max = DA9062AA_VLDO4_B,
>  	}, {
> -		.range_min = DA9062AA_BBAT_CONT,
> -		.range_max = DA9062AA_BBAT_CONT,
> -	}, {
>  		.range_min = DA9062AA_GP_ID_0,
>  		.range_max = DA9062AA_GP_ID_19,
>  	},

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog