linux-kernel - Re: [RFC][PATCH 1/3] rt_mutex: Add lockdep annotations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 6 Jun 2017 10:18:51 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     mingo@...nel.org, rostedt@...dmis.org, bigeasy@...utronix.de,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC][PATCH 1/3] rt_mutex: Add lockdep annotations

On Sun, Jun 04, 2017 at 04:26:43PM +0200, Thomas Gleixner wrote:
> On Wed, 31 May 2017, Peter Zijlstra wrote:
> 
> > Now that (PI) futexes have their own private RT-mutex interface and
> > implementation we can easily add lockdep annotations to the existing
> > RT-mutex interface.
> > 
> > Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> > ---
> >  include/linux/rtmutex.h        |   25 +++++++++++++++++++++----
> >  kernel/locking/rtmutex-debug.c |    6 +++++-
> 
> Shouldn't we get rid of all that home brewn rtmutex debug muck?

mutex also still has its mutex-debug.* stuff. It validates a little more
state. Also, and I think this is the main benefit, it has the magic bits
in that detect corruption without the full space/time costs of lockdep.

Maybe we can trim the rtmutex-debug a wee bit, but then futexes don't
get that coverage.

I'll put looking at this on the todo list.