linux-kernel - Re: [PATCH RESEND] mfd: arizona: Fix typo using hard-coded register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 6 Jun 2017 10:16:01 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:     a.hajda@...sung.com, patches@...nsource.cirrus.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] mfd: arizona: Fix typo using hard-coded register

On Tue, 06 Jun 2017, Charles Keepax wrote:

> A hardcoded register is accidentally used instead of the register
> address passed into the function. Correct this and use the appropriate
> variable. This would cause minor issues on wm5102, but all other
> devices using this driver would have been unaffected.
> 
> Fixes: commit ef84f885e037 ("mfd: arizona: Refactor arizona_poll_reg")
> Reported-by: Andrzej Hajda <a.hajda@...sung.com>
> Signed-off-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
> ---
>  drivers/mfd/arizona-core.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index 75488e6..8d46e3a 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -245,8 +245,7 @@ static int arizona_poll_reg(struct arizona *arizona,
>  	int ret;
>  
>  	ret = regmap_read_poll_timeout(arizona->regmap,
> -				       ARIZONA_INTERRUPT_RAW_STATUS_5, val,
> -				       ((val & mask) == target),
> +				       reg, val, ((val & mask) == target),
>  				       ARIZONA_REG_POLL_DELAY_US,
>  				       timeout_ms * 1000);
>  	if (ret)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog