linux-kernel - Re: [PATCH 0/7] dra7: Fixes for MMC devicetree node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Jun 2017 03:51:31 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     Kishon Vijay Abraham I <kishon@...com>
Cc:     Ulf Hansson <ulf.hansson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, Sekhar Nori <nsekhar@...com>,
        Russell King <linux@...linux.org.uk>,
        linux-omap <linux-omap@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>
Subject: Re: [PATCH 0/7] dra7: Fixes for MMC devicetree node

* Kishon Vijay Abraham I <kishon@...com> [170606 03:40]:
> omap3-overo-base.dtsi has the following dt node for mmc.
> /* optional on board WiFi */
> &mmc2 {
>         pinctrl-names = "default";
>         pinctrl-0 = <&mmc2_pins>;
>         vmmc-supply = <&w3cbw003c_npoweron>;
>         vqmmc-supply = <&w3cbw003c_bt_nreset>;
>         vmmc_aux-supply = <&w3cbw003c_wifi_nreset>;
>         bus-width = <4>;
>         cap-sdio-irq;
>         non-removable;
> };
> 
> It has both "vqmmc-supply" and "vmmc_aux-supply". However omap-hsmmc driver has
> never parsed vqmmc so far. So I'd assume bt was never functional and it's used
> only for wifi.

Hmm yeah the vqmmc-supply probably got copied from some
other SoC for w3cbw003c.

> So for the change suggested by Ulf, Can I do something like below, so that we
> can keep wifi functional (ignoring bt since that was never functional)?
> -       vqmmc-supply = <&w3cbw003c_bt_nreset>;
> -       vmmc_aux-supply = <&w3cbw003c_wifi_nreset>;
> +       vqmmc-supply = <&w3cbw003c_wifi_nreset>;

Optional sdio pins 4 - 8 need separate power and that's
why we have the vmmc_aux supply to start with. But here
there are only four pins, so my guess is that only one
regulator is needed and the the other two are gpio pins
for wland and bt that nowadays should be handled by the
mmc power sequence driver.

Regards,

Tony