[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 6 Jun 2017 13:07:44 +0200
From: Matthias Brugger <matthias.bgg@...il.com>
To: sean.wang@...iatek.com, herbert@...dor.apana.org.au,
mpm@...enic.com, robh+dt@...nel.org, mark.rutland@....com,
clabbe.montjoie@...il.com, prasannatsmkumar@...il.com,
romain.perier@...e-electrons.com, shannon.nelson@...cle.com
Cc: devicetree@...r.kernel.org, keyhaede@...il.com,
linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
linux-crypto@...r.kernel.org, weiyongjun1@...wei.com,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/4] dt-bindings: rng: add generic bindings for MediaTek
SoCs
On 31/05/17 20:44, sean.wang@...iatek.com wrote:
> From: Sean Wang <sean.wang@...iatek.com>
>
> Add the generic binding for allowing the support of RNG on MediaTek SoCs
> such as MT7622.
>
> Signed-off-by: Sean Wang <sean.wang@...iatek.com>
> ---
> Documentation/devicetree/bindings/rng/mtk-rng.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/rng/mtk-rng.txt b/Documentation/devicetree/bindings/rng/mtk-rng.txt
> index a6d62a2..0772913 100644
> --- a/Documentation/devicetree/bindings/rng/mtk-rng.txt
> +++ b/Documentation/devicetree/bindings/rng/mtk-rng.txt
> @@ -2,7 +2,8 @@ Device-Tree bindings for Mediatek random number generator
> found in Mediatek SoC family
>
> Required properties:
> -- compatible : Should be "mediatek,mt7623-rng"
> +- compatible : Should be "mediatek,generic-rng" or
> + "mediatek,mt7623-rng".
What does generic-rng mean. Is it for all mt7xxx, or also for mt6xxx and
mt8xxx based SoCs? I think we should stick with SoC specific bindings,
as we don't know if Mediatek won't publish a new IP block next year
which is differnet.
Just in case we should add a binding for the actual SoC + a fallback.
For example.
- compatible " Should be
"mediatek,mt7622-rng", "mediatek,mt7623-rng" for SoC mt7622
"mediatek,mt7623-rng" for SoC mt7623
This will also eliminate the need of adding mt6722-rng to the driver, as
it will use mt7623-rng as fallback. If in the future we realize that
mt7622-rng has a extra feature/bug, we can still work around it, without
breaking the bindings.
Makes sense?
Regards,
Matthias
> - clocks : list of clock specifiers, corresponding to
> entries in clock-names property;
> - clock-names : Should contain "rng" entries;
>
Powered by blists - more mailing lists