linux-kernel - Re: [PATCH 5/5] ARM: sun8i: a83t: add dwmac-sun8i ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Jun 2017 21:54:11 +0800
From:   Chen-Yu Tsai <wens@...e.org>
To:     Corentin Labbe <clabbe.montjoie@...il.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        Maxime Ripard <maxime.ripard@...e-electrons.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        devicetree <devicetree@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-sunxi <linux-sunxi@...glegroups.com>
Subject: Re: [PATCH 5/5] ARM: sun8i: a83t: add dwmac-sun8i ethernet driver

On Tue, Jun 6, 2017 at 3:21 AM, Corentin Labbe
<clabbe.montjoie@...il.com> wrote:
> The dwmac-sun8i is an ethernet MAC hardware that support 10/100/1000 speed.
> This patch enable the dwmac-sun8i on the Allwinner a83t SoC Device-tree.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com>
> ---
>  arch/arm/boot/dts/sun8i-a83t.dtsi | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
> index ae559dc42caa..304a966c8048 100644
> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi
> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
> @@ -200,6 +200,14 @@
>                         #interrupt-cells = <3>;
>                         #gpio-cells = <3>;
>
> +                       emac_rgmii_pins: emac0-pins {

I prefer emac-rgmii-pins for the node name.

> +                               pins = "PD2", "PD3", "PD4", "PD5", "PD6", "PD7",
> +                                      "PD11", "PD12", "PD13", "PD14", "PD18",
> +                                      "PD19", "PD21", "PD22", "PD23";
> +                               function = "gmac";
> +                               drive-strength = <40>;
> +                       };
> +
>                         mmc0_pins: mmc0-pins {
>                                 pins = "PF0", "PF1", "PF2",
>                                        "PF3", "PF4", "PF5";
> @@ -266,6 +274,26 @@
>                         status = "disabled";
>                 };
>
> +               emac: ethernet@...0000 {
> +                       compatible = "allwinner,sun8i-a83t-emac";
> +                       syscon = <&syscon>;
> +                       reg = <0x01c30000 0x104>;
> +                       interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
> +                       interrupt-names = "macirq";
> +                       resets = <&ccu 13>;
> +                       reset-names = "stmmaceth";
> +                       clocks = <&ccu 27>;
> +                       clock-names = "stmmaceth";
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       status = "disabled";
> +
> +                       mdio: mdio {
> +                               #address-cells = <1>;
> +                               #size-cells = <0>;
> +                       };
> +               };
> +
>                 gic: interrupt-controller@...1000 {
>                         compatible = "arm,cortex-a7-gic", "arm,cortex-a15-gic";
>                         reg = <0x01c81000 0x1000>,
> --
> 2.13.0
>

Otherwise,

Reviewed-by: Chen-Yu Tsai <wens@...e.org>