linux-kernel - Re: [PATCH v3] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Jun 2017 16:24:44 +0200
From:   Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>
To:     Archit Taneja <architt@...eaurora.org>,
        Eric Anholt <eric@...olt.net>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Thierry Reding <thierry.reding@...il.com>
Cc:     linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v3] drm/bridge: Refactor out the panel wrapper from the
 lvds-encoder bridge.

Op 05-06-17 om 12:08 schreef Archit Taneja:
>
>
> On 06/03/2017 01:55 AM, Eric Anholt wrote:
>> Many DRM drivers have common code to make a stub connector
>> implementation that wraps a drm_panel.  By wrapping the panel in a DRM
>> bridge, all of the connector code (including calls during encoder
>> enable/disable) goes away.
>>
>> v2: Fix build with CONFIG_DRM=m, drop "dev" argument that should just
>>     be the panel's dev, move kerneldoc up a level and document
>>     _remove().
>> v3: Fix another breakage with CONFIG_DRM=m, fix breakage with
>>     CONFIG_OF=n, move protos under CONFIG_DRM_PANEL_BRIDGE, wrap a
>>     line.
>>
>> Signed-off-by: Eric Anholt <eric@...olt.net>
>> Acked-by: Daniel Vetter <daniel.vetter@...ll.ch> (v1)
>> Reviewed-by: Boris Brezillon <boris.brezillon@...e-electrons.com> (v2)
>> Acked-by: Archit Taneja <architt@...eaurora.org> (v2)
>> ---
>>
>> New version of the first patch with build fixes.  I've re-pushed to
>> get another round of kbuild test, but if it comes back clean, I'd like
>> to merge this one, the vc4 patches (unchanged), and atmel-hlcdc (acked
>> by the maintainer).  I'd be dropping my STM patch (replaced by their
>> DSI series), and mediatek (I'd like an ack from the maintainer first).
>
> Thanks, I've locally picked up this patch and the following patches from
> the v2 series:
>
> [PATCH v2 2/7] drm/vc4: Switch DSI to the panel-bridge layer, and support bridges.
> [PATCH v2 3/7] drm/vc4: Switch DPI to using the panel-bridge helper.
> [PATCH v2 6/7] drm/atmel-hlcdc: Drop custom encoder cleanup func.
> [PATCH v2 7/7] drm/atmel-hlcdc: Replace the panel usage with drm_panel_bridge. 

This patch breaks support for building drm as module, because it imports some of the drm_kms_helper stuff.