linux-kernel - Re: [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 06 Jun 2017 08:33:49 -0700
From:   Joe Perches <joe@...ches.com>
To:     Greg KH <gregkh@...uxfoundation.org>,
        David Kershner <david.kershner@...sys.com>,
        Andy Whitcroft <apw@...onical.com>
Cc:     corbet@....net, tglx@...utronix.de, mingo@...nel.org,
        akpm@...ux-foundation.org, jes.sorensen@...il.com,
        linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
        driverdev-devel@...uxdriverproject.org, sparmaintainer@...sys.com
Subject: Re: [PATCH 0/3] move visorbus out of staging to
 drivers/virt/visorbus

On Tue, 2017-06-06 at 16:53 +0200, Greg KH wrote:
> On Tue, Jun 06, 2017 at 04:49:09PM +0200, Greg KH wrote:
> > I noticed that in drivers/staging/unisys/visorbus/visorbus_main.c, you
> > have 2 tabs for your 'struct attribute' variables, which is really odd.
[]
> Also, many of the attribute callbacks in that file seem to all have
> their leading '{' in the wrong place.  Odd that checkpatch.pl doesn't
> catch that...

checkpatch doesn't really check much about inconsistent
indentation.  I believe the only new statement indentation
check is after an if.

For instance, checkpatch doesn't emit a warning on this code:

struct foo {
		int bar;
};

struct foo *alloc_foo(void)
{
			struct foo *baz = malloc(sizeof(struct foo));
		if (baz)
			baz->bar = 1;
				return baz;
}