linux-kernel - Re: [PATCH 2/3] spi: mediatek: support adjust register define

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Jun 2017 19:57:30 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Leilk Liu <leilk.liu@...iatek.com>
Cc:     Mark Rutland <mark.rutland@....com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-spi@...r.kernel.org,
        linux-mediatek@...ts.infradead.org, sean.wang@...iatek.com
Subject: Re: [PATCH 2/3] spi: mediatek: support adjust register define

On Fri, Jun 02, 2017 at 03:18:42PM +0800, Leilk Liu wrote:

> +	/* some IC design adjust register define */
> +	bool adjust_reg;

Can we have a name that's more specific to the particular quirk please?
The current name will get confusing if some future chip also needs
slightly different register settings.

Otherwise this looks good.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)