[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 6 Jun 2017 21:30:58 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: linux-kernel@...r.kernel.org
Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>,
Paul Mackerras <paulus@...ba.org>,
Michael Ellerman <mpe@...erman.id.au>,
Vineet Gupta <vgupta@...opsys.com>,
Bart Van Assche <bart.vanassche@...disk.com>,
Robin Murphy <robin.murphy@....com>,
Joerg Roedel <jroedel@...e.de>,
Johan Hovold <johan@...nel.org>,
Alexey Kardashevskiy <aik@...abs.ru>,
Krzysztof Kozlowski <krzk@...nel.org>,
linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH 10/16] powerpc: vio: use dev_groups and not dev_attrs for
bus_type
On Tue, Jun 06, 2017 at 09:22:15PM +0200, Greg Kroah-Hartman wrote:
> The dev_attrs field has long been "depreciated" and is finally being
> removed, so move the driver to use the "correct" dev_groups field
> instead for struct bus_type.
>
> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Cc: Paul Mackerras <paulus@...ba.org>
> Cc: Michael Ellerman <mpe@...erman.id.au>
> Cc: Vineet Gupta <vgupta@...opsys.com>
> Cc: Bart Van Assche <bart.vanassche@...disk.com>
> Cc: Robin Murphy <robin.murphy@....com>
> Cc: Joerg Roedel <jroedel@...e.de>
> Cc: Johan Hovold <johan@...nel.org>
> Cc: Alexey Kardashevskiy <aik@...abs.ru>
> Cc: Krzysztof Kozlowski <krzk@...nel.org>
> Cc: <linuxppc-dev@...ts.ozlabs.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
> arch/powerpc/platforms/pseries/vio.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/pseries/vio.c b/arch/powerpc/platforms/pseries/vio.c
> index 28b09fd797ec..fd6595598662 100644
> --- a/arch/powerpc/platforms/pseries/vio.c
> +++ b/arch/powerpc/platforms/pseries/vio.c
> @@ -1537,6 +1537,7 @@ static ssize_t name_show(struct device *dev,
> {
> return sprintf(buf, "%s\n", to_vio_dev(dev)->name);
> }
> +static DEVICE_ATTR_RO(name);
>
> static ssize_t devspec_show(struct device *dev,
> struct device_attribute *attr, char *buf)
> @@ -1545,6 +1546,7 @@ static ssize_t devspec_show(struct device *dev,
>
> return sprintf(buf, "%s\n", of_node_full_name(of_node));
> }
> +static DEVICE_ATTR_RO(devspec);
>
> static ssize_t modalias_show(struct device *dev, struct device_attribute *attr,
> char *buf)
> @@ -1566,6 +1568,7 @@ static ssize_t modalias_show(struct device *dev, struct device_attribute *attr,
>
> return sprintf(buf, "vio:T%sS%s\n", vio_dev->type, cp);
> }
> +static DEVICE_ATTR_RO(modalias);
>
> static struct device_attribute vio_dev_attrs[] = {
> __ATTR_RO(name),
> @@ -1573,6 +1576,13 @@ static struct device_attribute vio_dev_attrs[] = {
> __ATTR_RO(modalias),
> __ATTR_NULL
> };
> +static struct attribute *vio_dev_attrs[] = {
Hm, this feels wrong, odd that 0-day passed it. I should be deleting
the above vio_dev_attrs field as well. Is powerpc really a dead
platform? :)
thanks,
greg k-h
Powered by blists - more mailing lists