linux-kernel - Re: [PATCH V1 2/2] pwm: pwm-qti-lpg: Add PWM driver for QTI LPG module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 7 Jun 2017 16:19:42 -0500
From:   Rob Herring <robh@...nel.org>
To:     fenglinw@...eaurora.org
Cc:     linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Thierry Reding <thierry.reding@...il.com>,
        Mark Rutland <mark.rutland@....com>, linux-pwm@...r.kernel.org,
        devicetree@...r.kernel.org, subbaram@...cinc.com,
        aghayal@....qualcomm.com, wruan@...cinc.com,
        kgunda@....qualcomm.com
Subject: Re: [PATCH V1 2/2] pwm: pwm-qti-lpg: Add PWM driver for QTI LPG
 module

On Wed, May 31, 2017 at 02:14:38PM +0800, fenglinw@...eaurora.org wrote:
> From: Fenglin Wu <fenglinw@...eaurora.org>
> 
> Add pwm_chip to support QTI LPG module and export LPG channels as
> PWM devices for consumer drivers' usage.
> 
> Signed-off-by: Fenglin Wu <fenglinw@...eaurora.org>
> ---
>  .../devicetree/bindings/pwm/pwm-qti-lpg.txt        |  39 ++

Please put binding in a separate patch.

>  drivers/pwm/Kconfig                                |  10 +
>  drivers/pwm/Makefile                               |   1 +
>  drivers/pwm/pwm-qti-lpg.c                          | 578 +++++++++++++++++++++
>  4 files changed, 628 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pwm/pwm-qti-lpg.txt
>  create mode 100644 drivers/pwm/pwm-qti-lpg.c
> 
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-qti-lpg.txt b/Documentation/devicetree/bindings/pwm/pwm-qti-lpg.txt
> new file mode 100644
> index 0000000..df81f5f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/pwm-qti-lpg.txt
> @@ -0,0 +1,39 @@
> +Qualcomm Technologies, Inc. LPG driver specific bindings
> +
> +This binding document describes the properties of LPG (Light Pulse Generator)
> +device module in Qualcomm Technologies, Inc. PMIC chips.
> +
> +- compatible:
> +	Usage: required
> +	Value type: <string>
> +	Definition: Must be "qcom,pwm-lpg".

Needs SoC specific compatible strings.

> +
> +- reg:
> +	Usage: required
> +	Value type: <prop-encoded-array>
> +	Definition: Register base and length for LPG modules. The length
> +		      varies based on the number of channels available in
> +		      the PMIC chips.
> +
> +- reg-names:
> +	Usage: required
> +	Value type: <string>
> +	Definition: The name of the register defined in the reg property.
> +		      It must be "lpg-base".

-names is pointless when there is only 1.

> +
> +- #pwm-cells:
> +	Usage: required
> +	Value type: <u32>
> +	Definition: The number of cells in "pwms" property specified in
> +		      PWM user nodes. It should be 2. The first cell is
> +		      the PWM channel ID indexed from 0, and the second
> +		      cell is the PWM default period in nanoseconds.
> +
> +Example:
> +
> +	pmi8998_lpg: lpg@...0 {
> +		compatible = "qcom,pwm-lpg";
> +		reg = <0xb100 0x600>;
> +		reg-names = "lpg-base";
> +		#pwm-cells = <2>;
> +	};