linux-kernel - Re: [PATCH v5] fpga manager: Add Altera CvP driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Jun 2017 02:51:07 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     kbuild test robot <lkp@...el.com>
Cc:     Anatolij Gustschin <agust@...x.de>, kbuild-all@...org,
        linux-fpga@...r.kernel.org, Alan Tull <atull@...nel.org>,
        Moritz Fischer <moritz.fischer@...us.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        matthew.gerlach@...ux.intel.com, yi1.li@...ux.intel.com
Subject: Re: [PATCH v5] fpga manager: Add Altera CvP driver

On Sun, May 14, 2017 at 10:01 PM, kbuild test robot <lkp@...el.com> wrote:
> Hi Anatolij,
>
> [auto build test ERROR on linus/master]
> [also build test ERROR on v4.12-rc1 next-20170512]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url:    https://github.com/0day-ci/linux/commits/Anatolij-Gustschin/fpga-manager-Add-Altera-CvP-driver/20170515-000247
> config: sparc-allyesconfig (attached as .config)
> compiler: sparc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
> reproduce:
>         wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=sparc
>
> All errors (new ones prefixed by >>):
>
>    drivers//fpga/altera-cvp.c: In function 'altera_cvp_write_init':
>>> drivers//fpga/altera-cvp.c:196:21: error: 'FPGA_MGR_COMPRESSED_BITSTREAM' undeclared (first use in this function)
>       if (info->flags & FPGA_MGR_COMPRESSED_BITSTREAM)
>                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    drivers//fpga/altera-cvp.c:196:21: note: each undeclared identifier is reported only once for each function it appears in


Anatolij, this is clearly bisectability error (I assume it compiles on
your side, thus means you have more patches on top of it).
Needs to be fixed and supplied along with you driver (I guess it's
FPGA Manager flags in fpga-mgr.h).

>
> vim +/FPGA_MGR_COMPRESSED_BITSTREAM +196 drivers//fpga/altera-cvp.c
>
>    190                          return -EINVAL;
>    191                  }
>    192
>    193                  if (info->flags & FPGA_MGR_ENCRYPTED_BITSTREAM)
>    194                          conf->numclks = 4; /* ratio for encrypted images */
>    195
>  > 196                  if (info->flags & FPGA_MGR_COMPRESSED_BITSTREAM)
>    197                          conf->numclks = 8; /* ratio for all compressed images */
>    198          }
>    199
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation



-- 
With Best Regards,
Andy Shevchenko