linux-kernel - Re: [PATCH v5 1/9] scatterlist: add sg_zeroout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0778ec96-8396-143e-9925-55f9c7d39239@suse.de>
Date:   Wed, 7 Jun 2017 09:00:50 +0200
From:   Johannes Thumshirn <jthumshirn@...e.de>
To:     Sagi Grimberg <sagi@...mberg.me>, Christoph Hellwig <hch@....de>,
        Keith Busch <keith.busch@...el.com>
Cc:     Hannes Reinecke <hare@...e.de>, maxg@...lanox.com,
        Linux NVMe Mailinglist <linux-nvme@...ts.infradead.org>,
        Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 1/9] scatterlist: add sg_zeroout_area() helper

On 06/06/2017 08:26 PM, Sagi Grimberg wrote:
> 
>> +    while ((offset < buflen) && sg_miter_next(&miter)) {
>> +        unsigned int len;
>> +
>> +        len = min(miter.length, buflen - offset);
>> +        memset(miter.addr, '\0', len);
> 
> Why '\0' and not 0?

Shouldn't be a difference, should it? ascii(7) says
'000   0     00    NUL '\0' (null character)'


-- 
Johannes Thumshirn                                          Storage
jthumshirn@...e.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850