linux-kernel - Re: [PATCH] mtd: nand: orion: Handle return value of clk_prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170607093233.2f950148@bbrezillon>
Date:   Wed, 7 Jun 2017 09:32:33 +0200
From:   Boris Brezillon <boris.brezillon@...e-electrons.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     richard@....at, dwmw2@...radead.org, computersforpeace@...il.com,
        marek.vasut@...il.com, cyrille.pitchen@...ev4u.fr,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: nand: orion: Handle return value of
 clk_prepare_enable

On Thu,  1 Jun 2017 16:28:15 +0530
Arvind Yadav <arvind.yadav.cs@...il.com> wrote:

> clk_prepare_enable() can fail here and we must check its return value.
> 

Applied.

Thanks,

Boris

> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
>  drivers/mtd/nand/orion_nand.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/orion_nand.c b/drivers/mtd/nand/orion_nand.c
> index f8e463a..209170e 100644
> --- a/drivers/mtd/nand/orion_nand.c
> +++ b/drivers/mtd/nand/orion_nand.c
> @@ -166,7 +166,11 @@ static int __init orion_nand_probe(struct platform_device *pdev)
>  		}
>  	}
>  
> -	clk_prepare_enable(info->clk);
> +	ret = clk_prepare_enable(info->clk);
> +	if (ret) {
> +		dev_err(&pdev->dev, "failed to prepare clock!\n");
> +		return ret;
> +	}
>  
>  	ret = nand_scan(mtd, 1);
>  	if (ret)