linux-kernel - Re: [PATCH v10] sun4i-codec: Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGb2v641CX=rM_2shHoM1XxMp82gwFMz-Y_95RBhP5jbjmU7dw@mail.gmail.com>
Date:   Wed, 7 Jun 2017 15:37:48 +0800
From:   Chen-Yu Tsai <wens@...e.org>
To:     Danny Milosavljevic <dannym@...atchpost.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Maxime Ripard <maxime.ripard@...e-electrons.com>,
        Chen-Yu Tsai <wens@...e.org>, Rob Herring <robh@...nel.org>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Linux-ALSA <alsa-devel@...a-project.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v10] sun4i-codec: Add mixer controls: Line-In, FM-In, Mic
 2, Capture Source, Differential Line-In.

On Wed, Jun 7, 2017 at 3:27 PM, Danny Milosavljevic
<dannym@...atchpost.org> wrote:
> Adds support for some mixer controls to sun4i-codec:
>  - Line-In
>  - FM-In
>  - Mic 2
>  - Capture Source
>  - Differential Line-In
>
> It also adds a mux for the capture source and the PGA for the MIC2 preamp.
>
> Where possible, it uses SOC_DAPM_DOUBLE in order to cut down on the number
> of distinct controls in alsamixer.

You are doing too many things in one patch.

Please split this up into 1 patch per control/mux/source/widget added,
preceded by patches for any required cleanups.

ChenYu

> Signed-off-by: Danny Milosavljevic <dannym@...atchpost.org>