linux-kernel - Re: [PATCH v3] drm/bridge: Build the panel wrapper in drm_kms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9be9f59f-3d6e-d68b-490e-68fa325a38fe@codeaurora.org>
Date:   Wed, 7 Jun 2017 13:49:19 +0530
From:   Archit Taneja <architt@...eaurora.org>
To:     Eric Anholt <eric@...olt.net>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Thierry Reding <thierry.reding@...il.com>
Cc:     linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v3] drm/bridge: Build the panel wrapper in drm_kms_helper



On 06/06/2017 11:22 PM, Eric Anholt wrote:
> Maarten Lankhorst <maarten.lankhorst@...ux.intel.com> writes:
>
>> This fixes the following depmod error when building drm as a module:
>> depmod: ERROR: Found 6 modules in dependency cycles!
>> depmod: ERROR: Cycle detected: drm -> drm_kms_helper -> drm
>>
>> Fixes: 13dfc0540a57 ("drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.")
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>
>
> Looks plausible to me.  Given how much trouble I've had getting the
> kbuild right, anyone else want to chime in?
>

The fix looks good to me too. depmod doesn't complain after this patch.

I can queue it to drm-misc-next if no one else has any comments on it
in the next few hours or so.

I'll make sure I check with 'make module_install' before pushing, I didn't
know depmod wasn't called otherwise.

Thanks,
Archit

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project