lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 07 Jun 2017 12:37:51 +0300 From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> To: "Williams, Dan J" <dan.j.williams@...el.com>, "hch@....de" <hch@....de> Cc: "mika.westerberg@...ux.intel.com" <mika.westerberg@...ux.intel.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>, "bp@...e.de" <bp@...e.de>, "rjw@...ysocki.net" <rjw@...ysocki.net>, "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org> Subject: Re: [PATCH v3 1/5] acpi, nfit: Switch to use new generic UUID API On Wed, 2017-06-07 at 06:25 +0000, Williams, Dan J wrote: > On Mon, 2017-06-05 at 23:22 +0200, Christoph Hellwig wrote: > > On Mon, Jun 05, 2017 at 08:10:42PM +0300, Andy Shevchenko wrote: > > > > > > I hope Christoph can replace old version of this series with new > > > one in > > > his uuid branch. URL in cover letter, repeating for your > > > convenience: > > > > > > [1]: git://git.infradead.org/users/hch/uuid.git > > > > Yeah, but I had to drop it again after noticing the guid_equals > > bits, > > and after not fixing up the GUID -> GUID_INIT rename. > > > > for-next in the above repo should have the proper base now, and acpi > > has the ACPI bits for Dan to test. > > With one compile fix below the 'acpi' branch works for me. Please feel > free to add: > > Tested-by: Dan Williams <dan.j.williams@...el.com> Thanks, Dan! I probably missed some configuration option since I have done compilation many times. > > ...to the changes that touch drivers/acpi/nfit/, drivers/nvdimm/, and > tools/testing/nvdimm, but I'm ok if you omit it if the branch is about > to go immutable. Speaking of which, let me know when it does go > immutable because the new libnvdimm enabling for ACPI 6.2 and EFI 2.7 > needs some new guid handling code. > > Please apply the following or fold it into commit c793ed7ccf42 "ACPI: > Switch to use generic guid_t in acpi_evaluate_dsm()" It think we may fold it. Besides that we might need the following fix as well. --- a/drivers/acpi/utils.c +++ b/drivers/acpi/utils.c @@ -638,7 +638,7 @@ acpi_evaluate_dsm(acpi_handle handle, const guid_t *guid, u64 rev, u64 func, params[0].type = ACPI_TYPE_BUFFER; params[0].buffer.length = 16; - params[0].buffer.pointer = (u8 *)&guid; + params[0].buffer.pointer = (u8 *)guid; params[1].type = ACPI_TYPE_INTEGER; params[1].integer.value = rev; params[2].type = ACPI_TYPE_INTEGER; -- Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Intel Finland Oy
Powered by blists - more mailing lists