linux-kernel - Re: [PATCH v1 1/3] mfd: Add new mfd device TPS68470

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201706071050.vRFv5vMX%fengguang.wu@intel.com>
Date:   Wed, 7 Jun 2017 10:10:09 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Rajmohan Mani <rajmohan.mani@...el.com>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org,
        linux-gpio@...r.kernel.org, linux-acpi@...r.kernel.org,
        Lee Jones <lee.jones@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Alexandre Courbot <gnurou@...il.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        Rajmohan Mani <rajmohan.mani@...el.com>
Subject: Re: [PATCH v1 1/3] mfd: Add new mfd device TPS68470

Hi Rajmohan,

[auto build test WARNING on ljones-mfd/for-mfd-next]
[also build test WARNING on v4.12-rc4 next-20170606]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Rajmohan-Mani/mfd-Add-new-mfd-device-TPS68470/20170607-080306
base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 6.2.0
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=ia64 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers/mfd/tps68470.c: In function 'tps68470_probe':
>> drivers/mfd/tps68470.c:175:3: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
      dev_err(tps->dev, "devm_regmap_init_i2c Error %d\n", ret);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/ret +175 drivers/mfd/tps68470.c

   159	
   160	static int tps68470_probe(struct i2c_client *client)
   161	{
   162		struct tps68470 *tps;
   163		int ret;
   164	
   165		tps = devm_kzalloc(&client->dev, sizeof(*tps), GFP_KERNEL);
   166		if (!tps)
   167			return -ENOMEM;
   168	
   169		mutex_init(&tps->lock);
   170		i2c_set_clientdata(client, tps);
   171		tps->dev = &client->dev;
   172	
   173		tps->regmap = devm_regmap_init_i2c(client, &tps68470_regmap_config);
   174		if (IS_ERR(tps->regmap)) {
 > 175			dev_err(tps->dev, "devm_regmap_init_i2c Error %d\n", ret);
   176			return PTR_ERR(tps->regmap);
   177		}
   178	
   179		ret = mfd_add_devices(tps->dev, -1, tps68470s,
   180				      ARRAY_SIZE(tps68470s), NULL, 0, NULL);
   181		if (ret < 0) {
   182			dev_err(tps->dev, "mfd_add_devices failed: %d\n", ret);
   183			return ret;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (49287 bytes)