linux-kernel - Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABxcv=mBXBYvi1z4pdeeA-nDuo10a1uJMe9=ZSqdRo-Q7uHQbg@mail.gmail.com>
Date:   Wed, 7 Jun 2017 16:27:53 +0200
From:   Javier Martinez Canillas <javier@...hile0.org>
To:     Keerthy <j-keerthy@...com>
Cc:     Enric Balletbo Serra <eballetbo@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Tony Lindgren <tony@...mide.com>, Milo Kim <milo.kim@...com>,
        "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/5] mfd: tps65217: Add a dependency on OF

On Wed, Jun 7, 2017 at 4:10 PM, Javier Martinez Canillas
<javier@...hile0.org> wrote:

[snip]

>>
>> chip_id = (unsigned long)match->data;
>>
>
> ...but this particular driver only has a single entry in the OF table
> and so you can just do:
>
> tps->id = TPS65217;
>

In fact, it seems that the whole chip id logic can go away since no
one is using it. I see that the regulator driver checks for the chip
id value but I don't think that makes sense since the regulator
driver's probe function won't be called for other chips since they
won't match.

Best regards,
Javier