linux-kernel - Re: [PATCH v2 1/3] arm64: hugetlb: Fix huge_pte_offset to return poisoned page table entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170607145855.cu5tob2uck2xbvxm@localhost>
Date:   Wed, 7 Jun 2017 15:58:55 +0100
From:   Catalin Marinas <catalin.marinas@....com>
To:     Punit Agrawal <punit.agrawal@....com>
Cc:     will.deacon@....com, David Woods <dwoods@...lanox.com>,
        steve.capper@....com, tbaicar@...eaurora.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        manoj.iyer@...onical.com
Subject: Re: [PATCH v2 1/3] arm64: hugetlb: Fix huge_pte_offset to return
 poisoned page table entries

On Wed, May 17, 2017 at 04:23:34PM +0100, Punit Agrawal wrote:
> When memory failure is enabled, a poisoned hugepage pte is marked as a
> swap entry. huge_pte_offset() does not return the poisoned page table
> entries when it encounters PUD/PMD hugepages.
> 
> This behaviour of huge_pte_offset() leads to error such as below when
> munmap is called on poisoned hugepages.
> 
> [  344.165544] mm/pgtable-generic.c:33: bad pmd 000000083af00074.
> 
> Fix huge_pte_offset() to return the poisoned pte which is then
> appropriately handled by the generic layer code.
> 
> Signed-off-by: Punit Agrawal <punit.agrawal@....com>
> Acked-by: Steve Capper <steve.capper@....com>
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: David Woods <dwoods@...lanox.com>

Since the patch matches my suggestions in v1:

Reviewed-by: Catalin Marinas <catalin.marinas@....com>