linux-kernel - Re: [PATCH 2/3] nvmem: core: add locking to nvmem_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24d689a7-bc27-e384-3741-efd9e6221bcb@linaro.org>
Date:   Wed, 7 Jun 2017 16:30:58 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Heiner Kallweit <hkallweit1@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] nvmem: core: add locking to nvmem_find_cell



On 04/06/17 12:01, Heiner Kallweit wrote:
> Adding entries to nvmem_cells and deleting entries from it is
> protected by nvmem_cells_mutex. Therefore this mutex should
> also protect iterating over the list.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
>  drivers/nvmem/core.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> index 4e07f3f8..1aa6d25a 100644
> --- a/drivers/nvmem/core.c
> +++ b/drivers/nvmem/core.c
> @@ -286,9 +286,15 @@ static struct nvmem_cell *nvmem_find_cell(const char *cell_id)
>  {
>  	struct nvmem_cell *p;
>
> +	mutex_lock(&nvmem_cells_mutex);
> +
>  	list_for_each_entry(p, &nvmem_cells, node)
> -		if (p && !strcmp(p->name, cell_id))
> +		if (p && !strcmp(p->name, cell_id)) {
> +			mutex_unlock(&nvmem_cells_mutex);
>  			return p;
> +		}
> +
> +	mutex_unlock(&nvmem_cells_mutex);
>
Thanks for the patch, I will queue this up.

Thanks,
srini
>  	return NULL;
>  }
>