linux-kernel - Re: [patch] compiler, clang: move inline definition to compiler-gcc.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 7 Jun 2017 09:41:38 -0700
From:   Matthias Kaehlcke <mka@...omium.org>
To:     David Rientjes <rientjes@...gle.com>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Arnd Bergmann <arnd@...db.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Ingo Molnar <mingo@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Christoph Hellwig <hch@....de>, Jens Axboe <axboe@...nel.dk>,
        Steven Rostedt <rostedt@...dmis.org>,
        Douglas Anderson <dianders@...omium.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Mark Brown <broonie@...nel.org>,
        David Miller <davem@...emloft.net>
Subject: Re: [patch] compiler, clang: move inline definition to compiler-gcc.h

El Tue, Jun 06, 2017 at 10:56:49PM -0700 David Rientjes ha dit:

> The motivation of commit abb2ea7dfd82 ("compiler, clang: suppress warning 
> for unused static inline functions") is to suppress clang's warnings about 
> unused static inline functions.
> 
> Clang defines __GNUC__ so it inherits all of compiler-gcc.h as well, so 
> the redefinition of `inline' ends up overriding the definition in 
> compiler-gcc.h.
> 
> Simply annotate all inline functions as __attribute__((unused)).  It's 
> necessary to suppress the warning for clang and is implicit with gcc.
> 
> Reported-by: Matthias Kaehlcke <mka@...omium.org>
> Signed-off-by: David Rientjes <rientjes@...gle.com>
> ---

Tested-by: Matthias Kaehlcke <mka@...omium.org>