linux-kernel - [PATCH] selftests: kselftest_harness: fix compile warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170607175731.18147-1-shuahkh@osg.samsung.com>
Date:   Wed,  7 Jun 2017 11:57:31 -0600
From:   Shuah Khan <shuahkh@....samsung.com>
To:     keescook@...omium.org, luto@...capital.net, wad@...omium.org,
        shuah@...nel.org
Cc:     Shuah Khan <shuahkh@....samsung.com>,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] selftests: kselftest_harness: fix compile warnings

Fix the following compile warns. checkpatch wants trailing statements
on next line.

gcc -Wl,-no-as-needed -Wall -lpthread seccomp_bpf.c -o
/lkml/linux-kselftest/tools/testing/selftests/seccomp/seccomp_bpf
In file included from seccomp_bpf.c:40:0:
seccomp_bpf.c: In function ‘change_syscall’:
../kselftest_harness.h:558:2: warning: this ‘for’ clause does not
guard... [-Wmisleading-indentation]
  for (; _metadata->trigger;  _metadata->trigger = __bail(_assert))
  ^
../kselftest_harness.h:574:14: note: in expansion of macro
‘OPTIONAL_HANDLER’
 } while (0); OPTIONAL_HANDLER(_assert)
              ^~~~~~~~~~~~~~~~
../kselftest_harness.h:440:2: note: in expansion of macro ‘__EXPECT’
  __EXPECT(expected, seen, ==, 0)
  ^~~~~~~~
seccomp_bpf.c:1313:2: note: in expansion of macro ‘EXPECT_EQ’
  EXPECT_EQ(0, ret);
  ^~~~~~~~~
seccomp_bpf.c:1317:2: note: ...this statement, but the latter is
misleadingly indented as if it is guarded by the ‘for’
  {
  ^
make: Leaving directory
'/lkml/linux-kselftest/tools/testing/selftests/seccomp'

Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
---
 tools/testing/selftests/kselftest_harness.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/kselftest_harness.h b/tools/testing/selftests/kselftest_harness.h
index c56f72e07cd7..432245faeab3 100644
--- a/tools/testing/selftests/kselftest_harness.h
+++ b/tools/testing/selftests/kselftest_harness.h
@@ -555,7 +555,8 @@
  * return while still providing an optional block to the API consumer.
  */
 #define OPTIONAL_HANDLER(_assert) \
-	for (; _metadata->trigger;  _metadata->trigger = __bail(_assert))
+	for (; _metadata->trigger;  _metadata->trigger = __bail(_assert)) \
+		;
 
 #define __EXPECT(_expected, _seen, _t, _assert) do { \
 	/* Avoid multiple evaluation of the cases */ \
-- 
2.11.0