linux-kernel - Re: [PATCH 03/20] asm-generic: Drop getrlimit and setrlimit syscalls from default list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170607184809.e4hmsvewkrmigmww@yury-thinkpad>
Date:   Wed, 7 Jun 2017 21:48:09 +0300
From:   Yury Norov <ynorov@...iumnetworks.com>
To:     James Hogan <james.hogan@...tec.com>
Cc:     Catalin Marinas <catalin.marinas@....com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
        Andrew Pinski <pinskia@...il.com>,
        Andrew Pinski <Andrew.Pinski@...iumnetworks.com>,
        Adam Borowski <kilobyte@...band.pl>,
        Chris Metcalf <cmetcalf@...hip.com>,
        Steve Ellcey <sellcey@...iumnetworks.com>,
        Maxim Kuvyrkov <maxim.kuvyrkov@...aro.org>,
        Ramana Radhakrishnan <ramana.gcc@...glemail.com>,
        Florian Weimer <fweimer@...hat.com>,
        Bamvor Zhangjian <bamvor.zhangjian@...wei.com>,
        Andreas Schwab <schwab@...e.de>,
        Chris Metcalf <cmetcalf@...lanox.com>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        schwidefsky@...ibm.com, broonie@...nel.org,
        Joseph Myers <joseph@...esourcery.com>,
        christoph.muellner@...obroma-systems.com, szabolcs.nagy@....com,
        klimov.linux@...il.com, Nathan_Lynch@...tor.com, agraf@...e.de,
        Prasun.Kapoor@...iumnetworks.com, geert@...ux-m68k.org,
        philipp.tomsich@...obroma-systems.com, manuel.montezelo@...il.com,
        linyongting@...wei.com, davem@...emloft.net,
        zhouchengming1@...wei.com, linux-arch@...r.kernel.org,
        linux-snps-arc@...ts.infradead.org,
        Will Deacon <will.deacon@....com>,
        Mark Salter <msalter@...hat.com>,
        Aurelien Jacquiot <a-jacquiot@...com>,
        linux-c6x-dev@...ux-c6x.org, Richard Kuo <rkuo@...eaurora.org>,
        linux-hexagon@...r.kernel.org, linux-metag@...r.kernel.org,
        Jonas Bonn <jonas@...thpole.se>, linux@...ts.openrisc.net,
        Chen Liqin <liqin.linux@...il.com>,
        Lennox Wu <lennox.wu@...il.com>,
        Guan Xuetao <gxt@...c.pku.edu.cn>,
        Ley Foon Tan <lftan@...era.com>,
        nios2-dev@...ts.rocketboards.org,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        uclinux-h8-devel@...ts.sourceforge.jp
Subject: Re: [PATCH 03/20] asm-generic: Drop getrlimit and setrlimit syscalls
 from default list

On Mon, Jun 05, 2017 at 03:44:06PM +0100, James Hogan wrote:
> Hi Yury,
> 
> On Sun, Jun 04, 2017 at 02:59:52PM +0300, Yury Norov wrote:
> > The newer prlimit64 syscall provides all the functionality provided by
> > the getrlimit and setrlimit syscalls and adds the pid of target process,
> > so future architectures won't need to include getrlimit and setrlimit.
> > 
> > Therefore drop getrlimit and setrlimit syscalls from the generic syscall
> > list unless __ARCH_WANT_SET_GET_RLIMIT is defined by the architecture's
> > unistd.h prior to including asm-generic/unistd.h, and adjust all architectures
> > using the generic syscall list to define it so that no in-tree architectures
> > are affected.
> > 
> > Cc: Arnd Bergmann <arnd@...db.de>
> > Cc: James Hogan <james.hogan@...tec.com>
> > Cc: linux-arch@...r.kernel.org
> > Cc: linux-snps-arc@...ts.infradead.org
> > Cc: Catalin Marinas <catalin.marinas@....com>
> > Cc: Will Deacon <will.deacon@....com>
> > Cc: linux-arm-kernel@...ts.infradead.org
> > Cc: Mark Salter <msalter@...hat.com>
> > Cc: Aurelien Jacquiot <a-jacquiot@...com>
> > Cc: linux-c6x-dev@...ux-c6x.org
> > Cc: Richard Kuo <rkuo@...eaurora.org>
> > Cc: linux-hexagon@...r.kernel.org
> > Cc: linux-metag@...r.kernel.org
> > Cc: Jonas Bonn <jonas@...thpole.se>
> > Cc: linux@...ts.openrisc.net
> > Cc: Chen Liqin <liqin.linux@...il.com>
> > Cc: Lennox Wu <lennox.wu@...il.com>
> > Cc: Chris Metcalf <cmetcalf@...lanox.com>
> > Cc: Guan Xuetao <gxt@...c.pku.edu.cn>
> > Cc: Ley Foon Tan <lftan@...era.com>
> > Cc: nios2-dev@...ts.rocketboards.org
> > Cc: Yoshinori Sato <ysato@...rs.sourceforge.jp>
> > Cc: uclinux-h8-devel@...ts.sourceforge.jp
> > Signed-off-by: Yury Norov <ynorov@...iumnetworks.com>
> > Acked-by: Arnd Bergmann <arnd@...db.de>
> > Acked-by: Mark Salter <msalter@...hat.com> [c6x]
> > Acked-by: James Hogan <james.hogan@...tec.com> [metag]
> > Acked-by: Ley Foon Tan <lftan@...era.com> [nios2]
> > Acked-by: Stafford Horne <shorne@...il.com> [openrisc]
> > Acked-by: Will Deacon <will.deacon@....com> [arm64]
> > Acked-by: Vineet Gupta <vgupta@...opsys.com> #arch/arc bits
> > ---
> >  arch/arc/include/uapi/asm/unistd.h       | 1 +
> >  arch/arm64/include/uapi/asm/unistd.h     | 1 +
> >  arch/c6x/include/uapi/asm/unistd.h       | 1 +
> >  arch/h8300/include/uapi/asm/unistd.h     | 1 +
> >  arch/hexagon/include/uapi/asm/unistd.h   | 1 +
> >  arch/metag/include/uapi/asm/unistd.h     | 1 +
> >  arch/nios2/include/uapi/asm/unistd.h     | 1 +
> >  arch/openrisc/include/uapi/asm/unistd.h  | 1 +
> >  arch/score/include/uapi/asm/unistd.h     | 1 +
> >  arch/tile/include/uapi/asm/unistd.h      | 1 +
> >  arch/unicore32/include/uapi/asm/unistd.h | 1 +
> >  include/uapi/asm-generic/unistd.h        | 5 +++++
> 
> Don't forget to add __IGNORE_getrlimit and __IGNORE_setrlimit to
> scripts/checksyscalls.sh, or you'll get warnings about missing syscalls.
> 
> Cheers
> James

Hi James,

Thanks for the hint.

Yury