linux-kernel - Re: [PATCH 02/17] pcie-xilinx: add missing 5th legacy interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMgXwTjuuE5YHoPJFA+mxGZU=Ck-Wr+A6SdNtpYk-dwQ7SeaBg@mail.gmail.com>
Date:   Wed, 7 Jun 2017 12:03:44 -0700
From:   Wesley Terpstra <wesley@...ive.com>
To:     Marc Zyngier <marc.zyngier@....com>
Cc:     Palmer Dabbelt <palmer@...belt.com>,
        Linux-Arch <linux-arch@...r.kernel.org>,
        linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
        Olof Johansson <olof@...om.net>, Albert Ou <albert@...ive.com>,
        patches@...ups.riscv.org, Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH 02/17] pcie-xilinx: add missing 5th legacy interrupt

On Wed, Jun 7, 2017 at 2:24 AM, Marc Zyngier <marc.zyngier@....com> wrote:
> This is a common problem with the current OF code that numbers INTx from
> 1 instead of zero (there is no 5th legacy interrupts in the PCI spec,
> despite what $SUBJECT says). I'd be inclined to fix this at the core
> level rather than papering over it in the various drivers...

While I agree that it's a problem with OF, every other driver has
already been changed to paper over the issue. This patch just brings
this one remaining OF-PCIe driver to the same level as the others.
Without the patch, the driver doesn't work at all if there is a bridge
chip on the other end of the controller, so this is not just a
hypothetical concern for us.

Couldn't the eventual OF fix just refactor this driver along with all
of the others? Doing such a sweeping OF change is outside my current
comfort zone. I am not familiar enough with the code to understand all
the parts that would need to be touched.