linux-kernel - Re: [PATCH 0/2] Add bcm2835aux interrupt controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89e725de-c77d-6a24-3ae5-9acb061cd6bb@raspberrypi.org>
Date:   Wed, 7 Jun 2017 21:55:27 +0100
From:   Phil Elwell <phil@...pberrypi.org>
To:     Stefan Wahren <stefan.wahren@...e.com>
Cc:     alexanders83@....de, linux-clk@...r.kernel.org,
        Stephen Boyd <sboyd@...eaurora.org>,
        Rob Herring <robh+dt@...nel.org>, linux-kernel@...r.kernel.org,
        linux-rpi-kernel@...ts.infradead.org,
        Eric Anholt <eric@...olt.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org
Subject: Re: [PATCH 0/2] Add bcm2835aux interrupt controller

On 07/06/2017 21:37, Stefan Wahren wrote:
> Hi Phil,
>
>> Phil Elwell <phil@...pberrypi.org> hat am 7. Juni 2017 um 13:11 geschrieben:
>>
>>
>> Devices in the AUX block share a common interrupt line, with a register
>> indicating which devices have active IRQs. Expose this as a nested
>> interrupt controller to avoid IRQ sharing problems (easily observed if
>> UART1 and SPI1/2 are enabled simultaneously).
>>
>> The interrupt functionality could arguably be forked off as a separate
>> irqchip driver, but the clock driver has already claimed the AUX_IRQ
>> register so some driver and DT surgery would still be required.
>> Eric Anholt thought that including it here is reasonable, but I'm
>> prepared to split it out if this is considered too hacky.
>
> in order to give the maintainers (e.g. irqchip) a chance, they should be included into CC.

Will do.

>> Phil Elwell (2):
>>   clk: bcm2835: Add AUX interrupt controller
>
> Either way the dt-binding must be updated as a separate patch. So Rob can review it.

Thanks, Stefan - I'll add that to v2.

Phil