linux-kernel - Re: [RFC PATCH 1/3] Add sysfs based cpuinfo structure.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 8 Jun 2017 20:22:53 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Felix Schnizlein <fschnizlein@...e.com>
Cc:     linux-kernel@...r.kernel.org, x86@...r.kernel.org,
        yanmin.zhang@...el.com, trenn@...e.com
Subject: Re: [RFC PATCH 1/3] Add sysfs based cpuinfo structure.

On Thu, Jun 08, 2017 at 06:56:13PM +0200, Felix Schnizlein wrote:
> Create a new sysfs attribute group called 'cpuinfo' for each
> online cpu. The cleaned up cpuinfo shows up in a sysfs
> subdirectory here: /sys/devices/system/cpu/cpu*/cpuinfo.
> 
> Define preprocessor macros (CPUINFO_DEFINE_* and CPUINFO_ATTR) to make
> defining new sysfs attributes for cpuinfo more easy.
> 
> Signed-off-by: Thomas Renninger <trenn@...e.com>

But not you?

> ---
>  drivers/base/Kconfig       |  7 ++++++
>  drivers/base/Makefile      |  1 +
>  drivers/base/cpuinfo.c     | 57 ++++++++++++++++++++++++++++++++++++++++++++++
>  include/linux/cpuhotplug.h |  1 +
>  include/linux/cpuinfo.h    | 47 ++++++++++++++++++++++++++++++++++++++
>  5 files changed, 113 insertions(+)
>  create mode 100644 drivers/base/cpuinfo.c
>  create mode 100644 include/linux/cpuinfo.h
> 
> diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
> index d718ae4..7900e31 100644
> --- a/drivers/base/Kconfig
> +++ b/drivers/base/Kconfig
> @@ -224,6 +224,13 @@ config DEBUG_TEST_DRIVER_REMOVE
>  	  unusable. You should say N here unless you are explicitly looking to
>  	  test this functionality.
>  
> +config CPUINFO_SYSFS
> +	bool "Enable sysfs based cpuinfo"
> +	depends on SYSFS && X86
> +	default y
> +	help
> +	  This option enables cpuinfo in sysfs.
> +
>  source "drivers/base/test/Kconfig"
>  
>  config SYS_HYPERVISOR
> diff --git a/drivers/base/Makefile b/drivers/base/Makefile
> index f2816f6..cbbba07 100644
> --- a/drivers/base/Makefile
> +++ b/drivers/base/Makefile
> @@ -23,6 +23,7 @@ obj-$(CONFIG_SOC_BUS) += soc.o
>  obj-$(CONFIG_PINCTRL) += pinctrl.o
>  obj-$(CONFIG_DEV_COREDUMP) += devcoredump.o
>  obj-$(CONFIG_GENERIC_MSI_IRQ_DOMAIN) += platform-msi.o
> +obj-$(CONFIG_CPUINFO_SYSFS) += cpuinfo.o
>  
>  obj-y			+= test/
>  
> diff --git a/drivers/base/cpuinfo.c b/drivers/base/cpuinfo.c
> new file mode 100644
> index 0000000..52c21f2
> --- /dev/null
> +++ b/drivers/base/cpuinfo.c
> @@ -0,0 +1,57 @@
> +/*
> + * Copyright (C) 2017 SUSE Linux GmbH
> + * Written by: Felix Schnizlein <fschnizlein@...e.com>
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License version
> + * 2 as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful, but
> + * WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; see the file COPYING.  If not, write to
> + * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
> + * Boston, MA 02110-1301 USA.

Did you run this through checkpatch.pl first?  Please do so :)

thanks,

greg k-h