linux-kernel - Re: [PATCH] IB/qib: remove duplicate code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170608145216.Horde.bIht4FUMAG95aZaBJGbeFqj@gator4166.hostgator.com>
Date:   Thu, 08 Jun 2017 14:52:16 -0500
From:   "Gustavo A. R. Silva" <garsilva@...eddedor.com>
To:     Dennis Dalessandro <dennis.dalessandro@...el.com>
Cc:     Mike Marciniszyn <infinipath@...el.com>,
        Doug Ledford <dledford@...hat.com>,
        Sean Hefty <sean.hefty@...el.com>,
        Hal Rosenstock <hal.rosenstock@...il.com>,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] IB/qib: remove duplicate code

Hi Dennis,

Quoting Dennis Dalessandro <dennis.dalessandro@...el.com>:

> On 6/7/2017 4:42 PM, Gustavo A. R. Silva wrote:
>> Remove duplicate code.
>>
>> Addresses-Coverity-ID: 1226951
>> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
>> ---
>>  drivers/infiniband/hw/qib/qib_mad.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/infiniband/hw/qib/qib_mad.c  
>> b/drivers/infiniband/hw/qib/qib_mad.c
>> index da295e0..c5eaa3c 100644
>> --- a/drivers/infiniband/hw/qib/qib_mad.c
>> +++ b/drivers/infiniband/hw/qib/qib_mad.c
>> @@ -874,8 +874,6 @@ static int subn_set_portinfo(struct ib_smp  
>> *smp, struct ib_device *ibdev,
>>  		ib_dispatch_event(&event);
>>  	}
>>  -	ret = subn_get_portinfo(smp, ibdev, port);
>> -
>>  	/* restore re-reg bit per o14-12.2.1 */
>>  	pip->clientrereg_resv_subnetto |= clientrereg;
>>
>
> Would be nice to see a few more words in the commit message rather  
> than having to go look for Coverity.
>

I'll take note of that.

> Regardless, patch seems fine to me code wise.
>
> Reviewed-by: Dennis Dalessandro <dennis.dalessandro@...el.com>

Thank you
--
Gustavo A. R. Silva