linux-kernel - Re: [PATCH 2/3] fs/locks: Remove fl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <201706081429.wGkVsweB%fengguang.wu@intel.com>
Date:   Thu, 8 Jun 2017 14:50:41 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Benjamin Coddington <bcodding@...hat.com>
Cc:     kbuild-all@...org, Jeff Layton <jlayton@...chiereds.net>,
        bfields@...ldses.org, Alexander Viro <viro@...iv.linux.org.uk>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] fs/locks: Remove fl_nspid

Hi Benjamin,

[auto build test WARNING on jlayton/linux-next]
[also build test WARNING on next-20170607]
[cannot apply to linus/master linux/master v4.12-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Benjamin-Coddington/fs-locks-Use-allocation-rather-than-the-stack-in-fcntl_getlk/20170608-015328
base:   git://git.samba.org/jlayton/linux linux-next
reproduce: make htmldocs

All warnings (new ones prefixed by >>):

   fs/inode.c:1664: warning: No description found for parameter 'rcu'
>> fs/locks.c:2052: warning: No description found for parameter 'init_nr'
>> fs/locks.c:2052: warning: Excess function parameter 'nr' description in 'locks_translate_pid'
>> fs/locks.c:2052: warning: No description found for parameter 'init_nr'
>> fs/locks.c:2052: warning: Excess function parameter 'nr' description in 'locks_translate_pid'
   include/linux/jbd2.h:442: warning: No description found for parameter 'i_transaction'
   include/linux/jbd2.h:442: warning: No description found for parameter 'i_next_transaction'
   include/linux/jbd2.h:442: warning: No description found for parameter 'i_list'
   include/linux/jbd2.h:442: warning: No description found for parameter 'i_vfs_inode'
   include/linux/jbd2.h:442: warning: No description found for parameter 'i_flags'
   include/linux/jbd2.h:496: warning: No description found for parameter 'h_rsv_handle'
   include/linux/jbd2.h:496: warning: No description found for parameter 'h_reserved'
   include/linux/jbd2.h:496: warning: No description found for parameter 'h_type'
   include/linux/jbd2.h:496: warning: No description found for parameter 'h_line_no'
   include/linux/jbd2.h:496: warning: No description found for parameter 'h_start_jiffies'
   include/linux/jbd2.h:496: warning: No description found for parameter 'h_requested_credits'
   include/linux/jbd2.h:496: warning: No description found for parameter 'saved_alloc_context'
   include/linux/jbd2.h:1049: warning: No description found for parameter 'j_chkpt_bhs'
   include/linux/jbd2.h:1049: warning: No description found for parameter 'j_devname'
   include/linux/jbd2.h:1049: warning: No description found for parameter 'j_average_commit_time'
   include/linux/jbd2.h:1049: warning: No description found for parameter 'j_min_batch_time'
   include/linux/jbd2.h:1049: warning: No description found for parameter 'j_max_batch_time'
   include/linux/jbd2.h:1049: warning: No description found for parameter 'j_commit_callback'
   include/linux/jbd2.h:1049: warning: No description found for parameter 'j_failed_commit'
   include/linux/jbd2.h:1049: warning: No description found for parameter 'j_chksum_driver'
   include/linux/jbd2.h:1049: warning: No description found for parameter 'j_csum_seed'
   fs/jbd2/transaction.c:434: warning: No description found for parameter 'rsv_blocks'
   fs/jbd2/transaction.c:434: warning: No description found for parameter 'gfp_mask'
   fs/jbd2/transaction.c:434: warning: No description found for parameter 'type'
   fs/jbd2/transaction.c:434: warning: No description found for parameter 'line_no'
   fs/jbd2/transaction.c:511: warning: No description found for parameter 'type'
   fs/jbd2/transaction.c:511: warning: No description found for parameter 'line_no'
   fs/jbd2/transaction.c:641: warning: No description found for parameter 'gfp_mask'

vim +/init_nr +2052 fs/locks.c

  2036	{
  2037		if (filp->f_op->lock && is_remote_lock(filp))
  2038			return filp->f_op->lock(filp, F_GETLK, fl);
  2039		posix_test_lock(filp, fl);
  2040		return 0;
  2041	}
  2042	EXPORT_SYMBOL_GPL(vfs_test_lock);
  2043	
  2044	/**
  2045	 * locks_translate_pid - translate a pid number into a namespace
  2046	 * @nr: The pid number in the init_pid_ns
  2047	 * @ns: The namespace into which the pid should be translated
  2048	 *
  2049	 * Used to tranlate a fl_pid into a namespace virtual pid number
  2050	 */
  2051	static pid_t locks_translate_pid(int init_nr, struct pid_namespace *ns)
> 2052	{
  2053		pid_t vnr = 0;
  2054		struct task_struct *task;
  2055	
  2056		rcu_read_lock();
  2057		task = find_task_by_pid_ns(init_nr, &init_pid_ns);
  2058		if (task)
  2059			get_task_struct(task);
  2060		rcu_read_unlock();

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (6634 bytes)