linux-kernel - Re: [PATCH 2/2] HID: usbhid: Add HID_QUIRK_NO_INIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170608072922.GJ16591@mail.corp.redhat.com>
Date:   Thu, 8 Jun 2017 09:29:22 +0200
From:   Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:     Philipp Zabel <philipp.zabel@...il.com>
Cc:     linux-input@...r.kernel.org, Jiri Kosina <jikos@...nel.org>,
        linux-usb <linux-usb@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] HID: usbhid: Add HID_QUIRK_NO_INIT_REPORTS for
 Oculus Rift CV1

On Jun 08 2017 or thereabouts, Philipp Zabel wrote:
> Hi Benjamin,
> 
> On Wed, Jun 7, 2017 at 9:11 AM, Benjamin Tissoires
> <benjamin.tissoires@...hat.com> wrote:
> > Hi Philip,
> >
> > On Jun 07 2017 or thereabouts, Philipp Zabel wrote:
> [...]
> > 2 things:
> > - the 2 patches should be squashed together. There is no point having a
> >   single patch for just 2 defines not used anywhere else.
> > - I believe you don't even need this quirk in the development version of
> >   the hid tree. Would you mind trying a plain v4.12-rcX and report if
> >   you still need the quirk?
> 
> Thanks, you are right. I just checked on v4.12-rc4 and now it works without
> the quirk. Sorry for the noise.

No worries. It's always interesting to know that we introduced a patch
that actually fixes hardware :)

So thanks for the report and the attempt :)

Cheers,
Benjamin