linux-kernel - Re: [PATCH 1/2] ip_tunnel: fix potential issue in ip_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <E030598F-13EC-4816-965E-FC24D86DA5CF@cmss.chinamobile.com>
Date:   Thu, 8 Jun 2017 08:10:07 +0800
From:   严海双 <yanhaishuang@...s.chinamobile.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ip_tunnel: fix potential issue in ip_tunnel_rcv


> On 7 Jun 2017, at 10:48 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> 
> On Wed, 2017-06-07 at 22:16 +0800, Haishuang Yan wrote:
>> When ip_tunnel_rcv fails, the tun_dst won't be freed, so move
>> skb_dst_set to begin and tun_dst would be freed by kfree_skb.
>> 
>> Signed-off-by: Haishuang Yan <yanhaishuang@...s.chinamobile.com>
>> ---
> 
> Please add the missing Fixes: tag and CC author of the patch that added
> this bug, so that he has a chance to comment and avoid future similar
> bugs.
> 
> Thanks.
> 
> 
> 

Ok, I will add these information in v2 commit.
Thanks.