linux-kernel - Re: [PATCH v3 11/15] perf header: add a buffer to struct feat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170608115422.GA29151@krava>
Date:   Thu, 8 Jun 2017 13:54:22 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     David Carrillo-Cisneros <davidcc@...gle.com>
Cc:     linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>, Simon Que <sque@...omium.org>,
        Wang Nan <wangnan0@...wei.com>, Jiri Olsa <jolsa@...nel.org>,
        He Kuang <hekuang@...wei.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Stephane Eranian <eranian@...gle.com>,
        Paul Turner <pjt@...gle.com>
Subject: Re: [PATCH v3 11/15] perf header: add a buffer to struct feat_fd

On Tue, Jun 06, 2017 at 12:07:18AM -0700, David Carrillo-Cisneros wrote:

SNIP

>  static int do_read_u32(struct feat_fd *ff, u32 *addr)
> @@ -188,6 +233,10 @@ static char *do_read_string(struct feat_fd *ff)
>  static int write_tracing_data(struct feat_fd *ff,
>  			      struct perf_evlist *evlist)
>  {
> +	if (ff->buf) {
> +		WARN_ON("Pipe-mode doesn't supported write_tracing_data.\n");
> +		return -1;
> +	}

I think you need to use WARN or WARN_ONCE here, like:

	if (WARN_ONCE(ff->buf, "Pipe....."))
		return -1;

WARN_ON takes condition as an argument not string

jirka