linux-kernel - [PATCH cleanups/resubmit 0/4] Cleanups & Resubmissions for Random-dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170608122932.23769-1-Jason@zx2c4.com>
Date:   Thu,  8 Jun 2017 14:29:28 +0200
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Theodore Ts'o <tytso@....edu>, LKML <linux-kernel@...r.kernel.org>
Cc:     "Jason A. Donenfeld" <Jason@...c4.com>
Subject: [PATCH cleanups/resubmit 0/4] Cleanups & Resubmissions for Random-dev

Hi Ted,

I'm not super sure what your workflow is like, but yesterday you picked
up my v4 instead of my v5, and as you applied the wrong commits, I sent
you several emails notifying you, along with quick fixes to various issues,
which you also did not see. I assume you have complicated email filters,
or maybe something like offlineimap where you grab snapshots of email,
and thus the only way to make an impact on an in-motion workflow is for me
to just formally resubmit things. So, here's a summary of what's in here:

  security/keys: ensure RNG is seeded before use

You had noticed an issue with this in v4/v5, so now this is cleaned up
the way you suggested so that you can merge it.

  random: squelch sh compiler warning and ensure safe optimization

This was the biggie -- I had incorporated this fix into v5, but you picked
up v4, so this commit is an additional one to bring your tree up to date,
without having to rebase or rewrite history.

  bluetooth/smp: ensure RNG is properly seeded before ECDH use

This one is pending your approval from the bluetooth people.

  crypto/rng: ensure that the RNG is ready before using

This one I assume you didn't pick up because it depends on my big_keys
rewrite going through.

Sorry for the procedural back-and-forth. If there's a way to do this flow
better next time, do tell me what it is. Alternatively, if you're ever on
IRC, realtime chat could be useful.

Regards,
Jason

 crypto/rng.c                             |  6 ++++--
 drivers/char/random.c                    |  8 ++++----
 net/bluetooth/hci_request.c              |  6 ++++++
 net/bluetooth/smp.c                      | 18 ++++++++++++++----
 security/keys/encrypted-keys/encrypted.c |  8 +++++---
 security/keys/key.c                      |  8 +++-----
 6 files changed, 36 insertions(+), 18 deletions(-)

-- 
2.13.0