linux-kernel - Re: [PATCH 2/7] scsi: ibmvscsi_tgt: remove use of class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <2a7a2937-9f0e-de01-1690-21cf92bb45f2@linux.vnet.ibm.com>
Date:   Thu, 8 Jun 2017 07:31:43 -0500
From:   "Bryant G. Ly" <bryantly@...ux.vnet.ibm.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Cc:     Michael Cyr <mikecyr@...ux.vnet.ibm.com>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, target-devel@...r.kernel.org
Subject: Re: [PATCH 2/7] scsi: ibmvscsi_tgt: remove use of class_attrs


> The class_attrs pointer is going away and it's not even being used in
> this driver, so just remove it entirely.
>
> Cc: "Bryant G. Ly" <bryantly@...ux.vnet.ibm.com>
> Cc: Michael Cyr <mikecyr@...ux.vnet.ibm.com>
> Cc: "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>
> Cc: "Martin K. Petersen" <martin.petersen@...cle.com>
> Cc: <linux-scsi@...r.kernel.org>
> Cc: <target-devel@...r.kernel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>   drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 5 -----
>   1 file changed, 5 deletions(-)
>
> diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
> index d390325c99ec..b480878e3258 100644
> --- a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
> +++ b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
> @@ -3915,10 +3915,6 @@ static const struct target_core_fabric_ops ibmvscsis_ops = {
>
>   static void ibmvscsis_dev_release(struct device *dev) {};
>
> -static struct class_attribute ibmvscsis_class_attrs[] = {
> -	__ATTR_NULL,
> -};
> -
>   static struct device_attribute dev_attr_system_id =
>   	__ATTR(system_id, S_IRUGO, system_id_show, NULL);
>
> @@ -3938,7 +3934,6 @@ ATTRIBUTE_GROUPS(ibmvscsis_dev);
>   static struct class ibmvscsis_class = {
>   	.name		= "ibmvscsis",
>   	.dev_release	= ibmvscsis_dev_release,
> -	.class_attrs	= ibmvscsis_class_attrs,
>   	.dev_groups	= ibmvscsis_dev_groups,
>   };
>
Thanks Greg, ACK.

-Bryant