linux-kernel - Re: [PATCH] platform/x86: constify rfkill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 8 Jun 2017 18:11:40 +0530
From:   Bhumika Goyal <bhumirks@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Julia Lawall <julia.lawall@...6.fr>,
        Pali Rohár <pali.rohar@...il.com>,
        "dvhart@...radead.org" <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Ike Panhc <ike.pan@...onical.com>,
        Corentin Chary <corentin.chary@...il.com>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: constify rfkill_ops structures

On Thu, Jun 8, 2017 at 6:08 PM, Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Thu, Jun 8, 2017 at 2:17 PM, Bhumika Goyal <bhumirks@...il.com> wrote:
>> Add const to rfkill_ops structures that are only passed as an argument
>> to the functions rfkill_alloc or samsung_new_rfkill. These arguments are
>> of type const, so such structures can be annotated with const.
>
> Change is fine by me, but please split to one patch per vendor.
>

Okay.

Thanks,
Bhumika

>>
>> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>
>> ---
>>  drivers/platform/x86/dell-rbtn.c      | 2 +-
>>  drivers/platform/x86/ideapad-laptop.c | 2 +-
>>  drivers/platform/x86/samsung-laptop.c | 4 ++--
>>  3 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/platform/x86/dell-rbtn.c b/drivers/platform/x86/dell-rbtn.c
>> index dcd9f40..6b5bbaf 100644
>> --- a/drivers/platform/x86/dell-rbtn.c
>> +++ b/drivers/platform/x86/dell-rbtn.c
>> @@ -110,7 +110,7 @@ static int rbtn_rfkill_set_block(void *data, bool blocked)
>>         return -EINVAL;
>>  }
>>
>> -static struct rfkill_ops rbtn_ops = {
>> +static const struct rfkill_ops rbtn_ops = {
>>         .query = rbtn_rfkill_query,
>>         .set_block = rbtn_rfkill_set_block,
>>  };
>> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
>> index 24ca9fb..3beec1e 100644
>> --- a/drivers/platform/x86/ideapad-laptop.c
>> +++ b/drivers/platform/x86/ideapad-laptop.c
>> @@ -478,7 +478,7 @@ static int ideapad_rfk_set(void *data, bool blocked)
>>         return write_ec_cmd(priv->priv->adev->handle, opcode, !blocked);
>>  }
>>
>> -static struct rfkill_ops ideapad_rfk_ops = {
>> +static const struct rfkill_ops ideapad_rfk_ops = {
>>         .set_block = ideapad_rfk_set,
>>  };
>>
>> diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c
>> index 8c146e2..e1e8897 100644
>> --- a/drivers/platform/x86/samsung-laptop.c
>> +++ b/drivers/platform/x86/samsung-laptop.c
>> @@ -591,7 +591,7 @@ static int seclinux_rfkill_set(void *data, bool blocked)
>>                                  !blocked);
>>  }
>>
>> -static struct rfkill_ops seclinux_rfkill_ops = {
>> +static const struct rfkill_ops seclinux_rfkill_ops = {
>>         .set_block = seclinux_rfkill_set,
>>  };
>>
>> @@ -651,7 +651,7 @@ static void swsmi_rfkill_query(struct rfkill *rfkill, void *priv)
>>         rfkill_set_sw_state(rfkill, !ret);
>>  }
>>
>> -static struct rfkill_ops swsmi_rfkill_ops = {
>> +static const struct rfkill_ops swsmi_rfkill_ops = {
>>         .set_block = swsmi_rfkill_set,
>>         .query = swsmi_rfkill_query,
>>  };
>> --
>> 2.7.4
>>
>
>
>
> --
> With Best Regards,
> Andy Shevchenko