linux-kernel - Re: [PATCH v2] mfd: tps65217: Introduce dependency on CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Jun 2017 16:11:16 +0200
From:   Javier Martinez Canillas <javier@...hile0.org>
To:     Enric Balletbo Serra <eballetbo@...il.com>
Cc:     Keerthy <j-keerthy@...com>, Lee Jones <lee.jones@...aro.org>,
        Tony Lindgren <tony@...mide.com>,
        Mark Brown <broonie@...nel.org>,
        Jingoo Han <jingoohan1@...il.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Tero Kristo <t-kristo@...com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>
Subject: Re: [PATCH v2] mfd: tps65217: Introduce dependency on CONFIG_OF

On Thu, Jun 8, 2017 at 3:32 PM, Enric Balletbo Serra
<eballetbo@...il.com> wrote:
> Hi Keerthy:
>
> 2017-06-08 12:46 GMT+02:00 Keerthy <j-keerthy@...com>:
>> Currently the driver boots only via device tree hence add a
>> dependency on CONFIG_OF. This leaves with a bunch of unused code
>> so clean that up.
>>
>> Signed-off-by: Keerthy <j-keerthy@...com>
>

[snip]

>>
>>  config MFD_TPS65217
>>         tristate "TI TPS65217 Power Management / White LED chips"
>> -       depends on I2C
>> +       depends on I2C && OF
>
> I think you should append || COMPILE_TEST here.
>

For me it should be a separate patch, it's nice to have COMPILE_TEST
but not related to this change IMHO.

>>
>> -static const struct i2c_device_id tps65217_id_table[] = {
>> -       {"tps65217", TPS65217},
>> -       { /* sentinel */ }
>> -};
>> -MODULE_DEVICE_TABLE(i2c, tps65217_id_table);

Unfortunately you can't get rid of this table (yet) since the I2C
subsystem always reports a MODALIAS of the form "i2c:tps65217" even
when the devices have been registered via OF. There are only a couple
of drivers more to clean-up and then I'll post a patch that fixes the
I2C core to report a proper OF modalias. But for now, removing will
mean that module autoload will be broken for this driver.

Best regards,
Javier