linux-kernel - Re: [PATCH] arm: aspeed: Add clock-names property to timer node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a0EaqwmAMRWn--29e4Kt6zJA9kHL2dpj=7Uabn5hANxOA@mail.gmail.com>
Date:   Thu, 8 Jun 2017 16:34:15 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     Joel Stanley <joel@....id.au>, Andrew Jeffery <andrew@...id.au>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH] arm: aspeed: Add clock-names property to timer node

On Thu, Jun 8, 2017 at 3:26 PM, Daniel Lezcano
<daniel.lezcano@...aro.org> wrote:
> On Wed, Jun 07, 2017 at 04:29:50PM +0200, Arnd Bergmann wrote:
>> On Wed, Jun 7, 2017 at 2:52 PM, Daniel Lezcano
>> <daniel.lezcano@...aro.org> wrote:
>> > On Tue, Jun 06, 2017 at 11:41:11AM +0200, Arnd Bergmann wrote:
>> >> On Mon, Jun 5, 2017 at 10:59 AM, Joel Stanley <joel@....id.au> wrote:
>> >> > On Mon, Jun 5, 2017 at 5:18 PM, Andrew Jeffery <andrew@...id.au> wrote:
>> >> >> The merging of a number of clocksource drivers into fttmr010 means we
>> >> >> require clock-names to be specified in the Aspeed timer node, else the
>> >> >> clocksource fails to probe and boot hangs.
>> >> >
>> >> > Arnd,
>> >> >
>> >> > Linus' reworked timer driver will go into 4.13.
>> >> >
>> >> > Can we get this patch merged into 4.12 as a fix so we don't end up
>> >> > with a broken boot at any stage?
>> >>
>> >> Hmm, can't we make the driver backward-compatible and have it fall
>> >> back on the first clock if no clk named "PCLK" is found? Otherwise
>> >> you still have an incompatible change in the DT binding and it will
>> >> break if someone uses an older dtb with a newer kernel.
>> >
>> > I would like to avoid to hack the kernel code for backward DT compatible
>> > things.
>>
>> How about a fixup in the platform code to add the property then?
>
> Dunno, do you have an example?

armada_375_380_coherency_init() adds a "arm,io-coherent" property on
some machines, when the DT might be lacking this.

        Arnd