linux-kernel - Re: [PATCH 2/3] media: ngene: Replace semaphore stream

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a1x1VuNkvjkHM-e7b8pZ=A2W0iadUnSXTX=Z5cOTsV6+g@mail.gmail.com>
Date:   Thu, 8 Jun 2017 17:19:15 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Binoy Jayan <binoy.jayan@...aro.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Rajendra <rnayak@...eaurora.org>,
        Mark Brown <broonie@...nel.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Julia Lawall <Julia.Lawall@...6.fr>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Cao jin <caoj.fnst@...fujitsu.com>,
        Linux Media Mailing List <linux-media@...r.kernel.org>
Subject: Re: [PATCH 2/3] media: ngene: Replace semaphore stream_mutex with mutex

On Thu, Jun 8, 2017 at 12:04 PM, Binoy Jayan <binoy.jayan@...aro.org> wrote:
> The semaphore 'stream_mutex' is used as a simple mutex, so
> it should be written as one. Semaphores are going away in the future.
>
> Signed-off-by: Binoy Jayan <binoy.jayan@...aro.org>
> ---

Looks correct, though I wonder whether it would be nicer to move the
mutex_lock/unlock() to the caller to avoid repeating the unlock() five
times.

Either way,

Reviewed-by: Arnd Bergmann <arnd@...db.de>