linux-kernel - Re: [PATCH v8 02/34] [media] dt-bindings: Add bindings for i.MX media driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7edc53b-bdfc-4a82-1c6c-70bf1c4db84a@gmail.com>
Date:   Thu, 8 Jun 2017 10:08:35 -0700
From:   Steve Longerbeam <slongerbeam@...il.com>
To:     robh+dt@...nel.org, mark.rutland@....com
Cc:     kernel@...gutronix.de, mchehab@...nel.org, hverkuil@...all.nl,
        p.zabel@...gutronix.de, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-media@...r.kernel.org
Subject: Re: [PATCH v8 02/34] [media] dt-bindings: Add bindings for i.MX media
 driver



On 06/08/2017 09:45 AM, Steve Longerbeam wrote:
> Hi Rob, Mark,
> 
> Are there any remaining technical issues with this
> binding doc? At this point an Ack from you is the only
> thing holding up merge of the imx-media driver.
> 
>

Note that the Synopsys core in the i.MX6 is a differently configured
Synopsys core from the core as described in the bindings at [1].

Russell King provided more information on the differences between these
cores at [2]. They are essentially different devices.

So perhaps the "snps,dw-mipi-csi2" compatibility needs to be removed
from this binding, for now, until this driver is moved to drivers/media/
and is made compatible with other MIPI CSI-2 Synopsys cores with
different configurations.


[1] http://patchwork.ozlabs.org/patch/736177/
[2] <20170403150342.GZ7909@...00.armlinux.org.uk>

> 
> On 06/07/2017 11:33 AM, Steve Longerbeam wrote:
>> Add bindings documentation for the i.MX media driver.
>>
>> Signed-off-by: Steve Longerbeam <steve_longerbeam@...tor.com>
>> ---
>>   Documentation/devicetree/bindings/media/imx.txt | 47 
>> +++++++++++++++++++++++++
>>   1 file changed, 47 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/media/imx.txt
>>
>> diff --git a/Documentation/devicetree/bindings/media/imx.txt 
>> b/Documentation/devicetree/bindings/media/imx.txt
>> new file mode 100644
>> index 0000000..c1e1e2b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/imx.txt
>> @@ -0,0 +1,47 @@
>> +Freescale i.MX Media Video Device
>> +=================================
>> +
>> +Video Media Controller node
>> +---------------------------
>> +
>> +This is the media controller node for video capture support. It is a
>> +virtual device that lists the camera serial interface nodes that the
>> +media device will control.
>> +
>> +Required properties:
>> +- compatible : "fsl,imx-capture-subsystem";
>> +- ports      : Should contain a list of phandles pointing to camera
>> +        sensor interface ports of IPU devices
>> +
>> +example:
>> +
>> +capture-subsystem {
>> +    compatible = "fsl,imx-capture-subsystem";
>> +    ports = <&ipu1_csi0>, <&ipu1_csi1>;
>> +};
>> +
>> +
>> +mipi_csi2 node
>> +--------------
>> +
>> +This is the device node for the MIPI CSI-2 Receiver, required for MIPI
>> +CSI-2 sensors.
>> +
>> +Required properties:
>> +- compatible    : "fsl,imx6-mipi-csi2", "snps,dw-mipi-csi2";
>> +- reg           : physical base address and length of the register set;
>> +- clocks    : the MIPI CSI-2 receiver requires three clocks: hsi_tx
>> +          (the D-PHY clock), video_27m (D-PHY PLL reference
>> +          clock), and eim_podf;
>> +- clock-names    : must contain "dphy", "ref", "pix";
>> +- port@*        : five port nodes must exist, containing endpoints
>> +          connecting to the source and sink devices according to
>> +          of_graph bindings. The first port is an input port,
>> +          connecting with a MIPI CSI-2 source, and ports 1
>> +          through 4 are output ports connecting with parallel
>> +          bus sink endpoint nodes and correspond to the four
>> +          MIPI CSI-2 virtual channel outputs.
>> +
>> +Optional properties:
>> +- interrupts    : must contain two level-triggered interrupts,
>> +          in order: 100 and 101;
>>