linux-kernel - RE: Re: [PATCH] devfreq: exynos-ppmu: Staticize event list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170609002827epcms1p74adfa60f131853c9c7ab9826a921fb53@epcms1p7>
Date:   Fri, 09 Jun 2017 00:28:27 +0000
From:   MyungJoo Ham <myungjoo.ham@...sung.com>
To:     Chanwoo Choi <cw00.choi@...sung.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        Kukjin Kim <kgene@...nel.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: Re: [PATCH] devfreq: exynos-ppmu: Staticize event list

> Hi Krzysztof,
> 
> On 2017년 06월 08일 03:12, Krzysztof Kozlowski wrote:
> > The ppmu_events array is accessed only in this compilation unit so it
> > can be made static.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> > ---
> >  drivers/devfreq/event/exynos-ppmu.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
> > index 9b7350935b73..c68f3b5a10b5 100644
> > --- a/drivers/devfreq/event/exynos-ppmu.c
> > +++ b/drivers/devfreq/event/exynos-ppmu.c
> > @@ -44,7 +44,7 @@ struct exynos_ppmu {
> >  	{ "ppmu-event2-"#name, PPMU_PMNCNT2 },	\
> >  	{ "ppmu-event3-"#name, PPMU_PMNCNT3 }
> >  
> > -struct __exynos_ppmu_events {
> > +static struct __exynos_ppmu_events {
> >  	char *name;
> >  	int id;
> >  } ppmu_events[] = {
> > 
> 
> Looks good to me.
> Acked-by: Chanwoo Choi <cw00.choi@...sung.com>

Acked-by: MyungJoo Ham <myungjoo.ham@...sung.com>


Cheers,
MyungJoo