linux-kernel - Re: [PATCH] ALSA: vx: vx_pcm: constify vx_pcm_playback_ops and vx_pcm_capture

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hink51vs3.wl-tiwai@suse.de>
Date:   Fri, 09 Jun 2017 09:10:20 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Arvind Yadav" <arvind.yadav.cs@...il.com>
Cc:     <perex@...ex.cz>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: vx: vx_pcm: constify vx_pcm_playback_ops and vx_pcm_capture_ops.

On Fri, 09 Jun 2017 09:05:43 +0200,
Arvind Yadav wrote:
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>    7126	    240	      0	   7366	   1cc6	sound/drivers/vx/vx_pcm.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>    7382	      0	      0	   7382	   1cd6	sound/drivers/vx/vx_pcm.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

If you're going to send more similar patches like this and previous
one of pcsp, could you create a patchset containing all and send at
once?


thanks,

Takashi

> ---
>  sound/drivers/vx/vx_pcm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/drivers/vx/vx_pcm.c b/sound/drivers/vx/vx_pcm.c
> index ea7b377..d318a33 100644
> --- a/sound/drivers/vx/vx_pcm.c
> +++ b/sound/drivers/vx/vx_pcm.c
> @@ -873,7 +873,7 @@ static int vx_pcm_prepare(struct snd_pcm_substream *subs)
>  /*
>   * operators for PCM playback
>   */
> -static struct snd_pcm_ops vx_pcm_playback_ops = {
> +static const struct snd_pcm_ops vx_pcm_playback_ops = {
>  	.open =		vx_pcm_playback_open,
>  	.close =	vx_pcm_playback_close,
>  	.ioctl =	snd_pcm_lib_ioctl,
> @@ -1095,7 +1095,7 @@ static snd_pcm_uframes_t vx_pcm_capture_pointer(struct snd_pcm_substream *subs)
>  /*
>   * operators for PCM capture
>   */
> -static struct snd_pcm_ops vx_pcm_capture_ops = {
> +static const struct snd_pcm_ops vx_pcm_capture_ops = {
>  	.open =		vx_pcm_capture_open,
>  	.close =	vx_pcm_capture_close,
>  	.ioctl =	snd_pcm_lib_ioctl,
> -- 
> 1.9.1
> 
>