linux-kernel - Re: [PATCH v5 03/11] gpio-exar/8250-exar: Fix passing in of parent PCI device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdah8Bgo2Ga5RK8+9=dqr0pizSYd50wqQk++TyycW6=xnQ@mail.gmail.com>
Date:   Fri, 9 Jun 2017 09:21:48 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Jan Kiszka <jan.kiszka@...mens.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Alexandre Courbot <gnurou@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Sascha Weisenberger <sascha.weisenberger@...mens.com>
Subject: Re: [PATCH v5 03/11] gpio-exar/8250-exar: Fix passing in of parent
 PCI device

On Fri, Jun 2, 2017 at 9:28 AM, Jan Kiszka <jan.kiszka@...mens.com> wrote:

> This fixes reloading of the GPIO driver for the same platform device
> instance as created by the exar UART driver: First of all, the driver
> sets drvdata to its own value during probing and does not restore the
> original value on exit. But this won't help anyway as the core clears
> drvdata after the driver left.
>
> Set the platform device parent instead.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> Acked-by: Linus Walleij <linus.walleij@...aro.org>

If I get Gregs ACK on this I can merge patches 2-11 through the
GPIO tree.

Yours,
Linus Walleij