linux-kernel - Re: [PATCH 2/2] video: adp8870: move header file out of I2C realm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170609074845.nd6y7lpi5rzudxod@dell>
Date:   Fri, 9 Jun 2017 08:48:45 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Wolfram Sang <wsa@...-dreams.de>
Cc:     linux-i2c@...r.kernel.org, Steven Miao <realmz6@...il.com>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Jingoo Han <jingoohan1@...il.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        adi-buildroot-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, linux-fbdev@...r.kernel.org
Subject: Re: [PATCH 2/2] video: adp8870: move header file out of I2C realm

On Fri, 09 Jun 2017, Lee Jones wrote:

> On Mon, 22 May 2017, Wolfram Sang wrote:
> 
> > include/linux/i2c is not for client devices. Move the header file to a
> > more appropriate location.
> > 
> > Signed-off-by: Wolfram Sang <wsa@...-dreams.de>
> > ---
> >  arch/blackfin/mach-bf537/boards/stamp.c        | 2 +-
> >  drivers/video/backlight/adp8870_bl.c           | 2 +-
> >  include/linux/{i2c => platform_data}/adp8870.h | 0
> >  3 files changed, 2 insertions(+), 2 deletions(-)
> >  rename include/linux/{i2c => platform_data}/adp8870.h (100%)
> 
> Applied, thanks.

Scrap that.  I can't actually apply these without Steven's Ack.

> > diff --git a/arch/blackfin/mach-bf537/boards/stamp.c b/arch/blackfin/mach-bf537/boards/stamp.c
> > index 7db90c72bd8ddc..7528148dc4925b 100644
> > --- a/arch/blackfin/mach-bf537/boards/stamp.c
> > +++ b/arch/blackfin/mach-bf537/boards/stamp.c
> > @@ -1995,7 +1995,7 @@ static struct adp5588_gpio_platform_data adp5588_gpio_data = {
> >  #endif
> >  
> >  #if IS_ENABLED(CONFIG_BACKLIGHT_ADP8870)
> > -#include <linux/i2c/adp8870.h>
> > +#include <linux/platform_data/adp8870.h>
> >  static struct led_info adp8870_leds[] = {
> >  	{
> >  		.name = "adp8870-led7",
> > diff --git a/drivers/video/backlight/adp8870_bl.c b/drivers/video/backlight/adp8870_bl.c
> > index 21acac90fd773f..058d1def2d1f4b 100644
> > --- a/drivers/video/backlight/adp8870_bl.c
> > +++ b/drivers/video/backlight/adp8870_bl.c
> > @@ -18,7 +18,7 @@
> >  #include <linux/workqueue.h>
> >  #include <linux/slab.h>
> >  
> > -#include <linux/i2c/adp8870.h>
> > +#include <linux/platform_data/adp8870.h>
> >  #define ADP8870_EXT_FEATURES
> >  #define ADP8870_USE_LEDS
> >  
> > diff --git a/include/linux/i2c/adp8870.h b/include/linux/platform_data/adp8870.h
> > similarity index 100%
> > rename from include/linux/i2c/adp8870.h
> > rename to include/linux/platform_data/adp8870.h
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog