linux-kernel - Re: [PATCH v2 0/8] omap*: Fixes/Cleanups for MMC devicetree node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4a4c4eb2-d865-25e6-cd53-a74d4f7b1f62@ti.com>
Date:   Fri, 9 Jun 2017 13:35:58 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Ulf Hansson <ulf.hansson@...aro.org>
CC:     Tony Lindgren <tony@...mide.com>, Rob Herring <robh+dt@...nel.org>,
        Sekhar Nori <nsekhar@...com>,
        Russell King <linux@...linux.org.uk>,
        linux-omap <linux-omap@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>
Subject: Re: [PATCH v2 0/8] omap*: Fixes/Cleanups for MMC devicetree node

Hi,

On Thursday 08 June 2017 12:50 PM, Ulf Hansson wrote:
> On 7 June 2017 at 11:37, Kishon Vijay Abraham I <kishon@...com> wrote:
>> There are the set of fixes that were sent initially as part
>> of [1].
>>
>> These are mostly fixes w.r.t populating regulators in
>> mmc dt node. It was working before because the regulators
>> connecting to the IO lines are always on regulators. This will
>> break once we add UHS support where voltage has to be changed
>> dynamically.
>>
>> It also includes a patch to replace all vmmc_aux-supply
>> with vqmmc-supply (In omap3-overo-base.dtsi remove the existing
>> vqmmc-supply and then replace vmmc_aux-supply with vqmmc-supply).
>> This will break old dt compatibility but not sure how better
>> to handle this.
>>
>> Performed enumeration testing on dra72-evm-revc, dra72-evm,
>> dra7-evm, am572x-evm, am571x-idk, am572x-idk, omap5-evm,
>> pandaboard-es, am43xx-evm, am335x-evm, beagleboard etc.,
>>
>> This is a preparation series for adding UHS mode support in
>> the above mentioned platforms.
>>
>> Changes from v1:
>> *) Included a patch to replace deprecated "vmmc_aux" with
>>    "vqmmc"
>>
>> [1] -> https://lkml.org/lkml/2017/5/19/196
>>
>> Kishon Vijay Abraham I (6):
>>   ARM: dts: dra72-evm-common: Correct vmmc-supply for mmc2
>>   ARM: dts: dra72-evm: Add vqmmc supply to mmc1
>>   ARM: dts: dra72-evm-revc: Add vqmmc supply to mmc1
>>   ARM: dts: am57xx-beagle-x15-revb1: Fix supply name used for MMC1 IO
>>     lines
>>   ARM: dts: dra7: Add "max-frequency" property to MMC dt nodes
>>   ARM: dts: omap*: Replace deprecated "vmmc_aux" with "vqmmc"
>>
>> Ravikumar Kattekola (1):
>>   ARM: dts: dra7-evm: Correct the vmmc-supply for mmc2
>>
>> Sekhar Nori (1):
>>   ARM: OMAP2+: Add pdata-quirks for MMC/SD on DRA74x EVM
>>
>>  arch/arm/boot/dts/am572x-idk.dts               |  2 +-
>>  arch/arm/boot/dts/am57xx-beagle-x15-revb1.dts  |  2 +-
>>  arch/arm/boot/dts/dra7-evm.dts                 | 12 ++++++++--
>>  arch/arm/boot/dts/dra7.dtsi                    |  5 +++++
>>  arch/arm/boot/dts/dra71-evm.dts                | 16 ++++++++++++-
>>  arch/arm/boot/dts/dra72-evm-common.dtsi        |  2 --
>>  arch/arm/boot/dts/dra72-evm-revc.dts           | 18 +++++++++++++++
>>  arch/arm/boot/dts/dra72-evm-tps65917.dtsi      |  2 +-
>>  arch/arm/boot/dts/dra72-evm.dts                | 18 +++++++++++++++
>>  arch/arm/boot/dts/omap3-beagle-xm.dts          |  2 +-
>>  arch/arm/boot/dts/omap3-beagle.dts             |  2 +-
>>  arch/arm/boot/dts/omap3-cm-t3517.dts           |  2 +-
>>  arch/arm/boot/dts/omap3-cm-t3730.dts           |  2 +-
>>  arch/arm/boot/dts/omap3-devkit8000-common.dtsi |  2 +-
>>  arch/arm/boot/dts/omap3-evm-common.dtsi        |  2 +-
>>  arch/arm/boot/dts/omap3-n900.dts               |  2 +-
>>  arch/arm/boot/dts/omap3-overo-base.dtsi        |  3 +--
>>  arch/arm/boot/dts/omap3-tao3530.dtsi           |  2 +-
>>  arch/arm/boot/dts/omap3-zoom3.dts              |  2 +-
>>  arch/arm/boot/dts/omap3430-sdp.dts             |  2 +-
>>  arch/arm/mach-omap2/pdata-quirks.c             | 31 ++++++++++++++++++++++++++
>>  include/linux/platform_data/hsmmc-omap.h       |  3 +++
>>  22 files changed, 114 insertions(+), 20 deletions(-)
>>
>> --
>> 2.11.0
>>
> 
> If it helps, I can host a branch with the updates on the omap_hsmmc
> driver, such it can be pulled in from arm soc?
> 
> I guess you need that as, the DT changes relies on the new vqmmc
> binding. Or you thing it doesn't matter, because for the current
> changes that regulator is always an always on regulator?

Since there is fallback mechanism in omap_hsmmc driver (falls back to
vmmc_aux), dt changes shouldn't rely on the omap_hsmmc driver.

However I'll send a fix for omap3-overo-base which used vqmmc incorrectly (that
should be merged before omap_hsmmc driver changes) so that git bisect does not
break.

Thanks
Kishon