linux-kernel - Re: [PATCH 2/3] arm: dts: mt2701: Add display bls related nodes for MT2701

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82c8b877-ec34-bd37-7428-8af86191a66e@gmail.com>
Date:   Fri, 9 Jun 2017 10:12:50 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Erin Lo <erin.lo@...iatek.com>
Cc:     srv_heupstream@...iatek.com, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-mediatek@...ts.infradead.org, YT Shen <yt.shen@...iatek.com>,
        Weiqing Kong <weiqing.kong@...iatek.com>
Subject: Re: [PATCH 2/3] arm: dts: mt2701: Add display bls related nodes for
 MT2701



On 01/06/17 08:08, Erin Lo wrote:
> From: YT Shen <yt.shen@...iatek.com>

I miss the Singed-off-by from YT Shen.

> 
> This patch adds the device node of display backlight for MT2701
> 
> Signed-off-by: Weiqing Kong <weiqing.kong@...iatek.com>
> Signed-off-by: Erin Lo <erin.lo@...iatek.com>
> ---
>   arch/arm/boot/dts/mt2701-evb.dts | 29 +++++++++++++++++++++++++++++
>   arch/arm/boot/dts/mt2701.dtsi    |  9 +++++++++
>   2 files changed, 38 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/mt2701-evb.dts b/arch/arm/boot/dts/mt2701-evb.dts
> index a483798..e49c2b7 100644
> --- a/arch/arm/boot/dts/mt2701-evb.dts
> +++ b/arch/arm/boot/dts/mt2701-evb.dts
> @@ -22,6 +22,35 @@
>   	memory {
>   		reg = <0 0x80000000 0 0x40000000>;
>   	};
> +
> +	backlight_lcd: backlight_lcd {
> +		compatible = "pwm-backlight";
> +		pwms = <&bls 0 100000>;
> +		brightness-levels = <
> +			  0  16  32  48  64  80  96 112
> +			128 144 160 176 192 208 224 240
> +			255
> +		>;
> +		default-brightness-level = <9>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pwm_bls_gpio>;
> +	};
> +};
> +
> +&bls {
> +	status = "okay";
> +};
> +
> +&mmsys {
> +	status = "okay";
> +};
> +
> +&pio {
> +	pwm_bls_gpio: pwm_bls_gpio {
> +		pins_cmd_dat {
> +			pinmux = <MT2701_PIN_208_AUD_EXT_CK1__FUNC_DISP_PWM>;
> +		};
> +	};
>   };
>   
>   &auxadc {
> diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi
> index de88bd7..4f110d5 100644
> --- a/arch/arm/boot/dts/mt2701.dtsi
> +++ b/arch/arm/boot/dts/mt2701.dtsi
> @@ -366,6 +366,15 @@
>   		#clock-cells = <1>;
>   	};
>   
> +	bls: bls@...0a000 {
> +		compatible = "mediatek,mt2701-disp-pwm";
> +		reg = <0 0x1400a000 0 0x1000>;
> +		#pwm-cells = <2>;
> +		clocks = <&mmsys CLK_MM_MDP_BLS_26M>, <&mmsys CLK_MM_DISP_BLS>;
> +		clock-names = "main", "mm";
> +		status = "disabled";
> +	};
> +

Can you make this a new patch please. It's preferred to have one patch 
for the dtsi and another one for the actual board.

Thanks,
Matthias

>   	larb0: larb@...10000 {
>   		compatible = "mediatek,mt2701-smi-larb";
>   		reg = <0 0x14010000 0 0x1000>;
>